Commit 7d9d52f
committed
benchmark-lsp: make testing more consistent/fair
Some linters, such as ESLint, run in two phases: parse, then lint.
'let x, x;' causes some linters to fail during the first phase, meaning
the second phase doesn't run. This makes those linters look faster than
they actually are.
Fix the error-producing pattern used in our benchmarks to activate only
during the last phase of multi-phase linters.
On my fast Linux machine, this changes
eslint-server/open-wait-close/edex-ui-filesystem.class.js from
44.3~50.8 ms to 69.9~83.4 ms.1 parent ab2380e commit 7d9d52f
File tree
3 files changed
+3
-3
lines changed- benchmark/benchmark-lsp/corpus
3 files changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
740 | 740 | | |
741 | 741 | | |
742 | 742 | | |
743 | | - | |
| 743 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
660 | 660 | | |
661 | 661 | | |
662 | 662 | | |
663 | | - | |
| 663 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments