refactor(lsp): split function into parsing func + logic func

Author: strager

src/quick-lint-js/lsp/lsp-server.cpp

@@ -686,16 +686,15 @@ void linting_lsp_server_handler::apply_document_changes(
 
 void linting_lsp_server_handler::apply_document_change(
     quick_lint_js::document<lsp_locator>& doc,
-    ::simdjson::ondemand::object& change) {
-  string8_view change_text;
-  if (!get_string8(change, "text", &change_text)) {
+    ::simdjson::ondemand::object& raw_change) {
+  lsp_document_change change;
+  if (!get_string8(raw_change, "text", &change.text)) {
     // Ignore invalid change.
     return;
   }
   ::simdjson::ondemand::object raw_range;
-  bool is_incremental = get_object(change, "range", &raw_range);
-  if (is_incremental) {
-    lsp_range range;
+  if (get_object(raw_change, "range", &raw_range)) {
+    lsp_range& range = change.range.emplace();
 
     ::simdjson::ondemand::object start;
     if (!(get_object(raw_range, "start", &start) &&
@@ -712,10 +711,18 @@ void linting_lsp_server_handler::apply_document_change(
       // Ignore invalid change.
       return;
     }
+  }
+
+  apply_document_change(doc, change);
+}
 
-    doc.replace_text(range, change_text);
+void linting_lsp_server_handler::apply_document_change(
+    quick_lint_js::document<lsp_locator>& doc,
+    const lsp_document_change& change) {
+  if (change.range.has_value()) {
+    doc.replace_text(*change.range, change.text);
   } else {
-    doc.set_text(change_text);
+    doc.set_text(change.text);
   }
 }
 

src/quick-lint-js/lsp/lsp-server.h

@@ -206,10 +206,17 @@ class linting_lsp_server_handler final : public lsp_endpoint_handler {
                                                loaded_config_file*,
                                                byte_buffer& out_json);
 
+  struct lsp_document_change {
+    string8_view text;
+    // If a range is not provided, the document's text is entirely replaced.
+    std::optional<lsp_range> range;
+  };
   static void apply_document_changes(quick_lint_js::document<lsp_locator>& doc,
                                      ::simdjson::ondemand::array& changes);
   static void apply_document_change(quick_lint_js::document<lsp_locator>& doc,
-                                    ::simdjson::ondemand::object& change);
+                                    ::simdjson::ondemand::object& raw_change);
+  static void apply_document_change(quick_lint_js::document<lsp_locator>& doc,
+                                    const lsp_document_change& change);
 
   static void write_method_not_found_error_response(
       string8_view request_id_json, byte_buffer&);