refactor(lsp): reduce #include bloat with PIMPL

Author: strager

src/quick-lint-js/lsp/lsp-endpoint.cpp

@@ -32,7 +32,11 @@ lsp_endpoint_handler::~lsp_endpoint_handler() = default;
 
 lsp_endpoint::lsp_endpoint(lsp_endpoint_handler* handler,
                            lsp_endpoint_remote* remote)
-    : remote_(remote), handler_(handler) {}
+    : remote_(remote),
+      handler_(handler),
+      json_parser_(std::make_unique< ::simdjson::ondemand::parser>()) {}
+
+lsp_endpoint::~lsp_endpoint() = default;
 
 void lsp_endpoint::message_parsed(string8_view message) {
   trace_writer* tw =
@@ -53,7 +57,8 @@ void lsp_endpoint::message_parsed(string8_view message) {
       reinterpret_cast<const char*>(message.data()), message.size());
   ::simdjson::ondemand::document message_document;
   ::simdjson::error_code parse_error;
-  this->json_parser_.iterate(padded_message).tie(message_document, parse_error);
+  this->json_parser_->iterate(padded_message)
+      .tie(message_document, parse_error);
   if (parse_error != ::simdjson::error_code::SUCCESS) {
     byte_buffer error_json;
     this->write_json_parse_error_response(error_json);

src/quick-lint-js/lsp/lsp-endpoint.h

@@ -9,6 +9,7 @@
 #else
 
 #include <cstddef>
+#include <memory>
 #include <quick-lint-js/assert.h>
 #include <quick-lint-js/container/byte-buffer.h>
 #include <quick-lint-js/json.h>
@@ -17,8 +18,7 @@
 #include <quick-lint-js/port/have.h>
 #include <quick-lint-js/port/unreachable.h>
 #include <quick-lint-js/port/warning.h>
-#include <quick-lint-js/simdjson.h>
-#include <simdjson.h>
+#include <quick-lint-js/simdjson-fwd.h>
 #include <tuple>
 #include <utility>
 #include <vector>
@@ -114,6 +114,10 @@ class lsp_endpoint : private lsp_message_parser<lsp_endpoint> {
   //     better.
   explicit lsp_endpoint(lsp_endpoint_handler* handler,
                         lsp_endpoint_remote* remote);
+  ~lsp_endpoint();
+
+  lsp_endpoint(const lsp_endpoint&) = delete;
+  lsp_endpoint& operator=(const lsp_endpoint&) = delete;
 
   using message_parser::append;
 
@@ -130,9 +134,7 @@ class lsp_endpoint : private lsp_message_parser<lsp_endpoint> {
 
   lsp_endpoint_remote* remote_;
   lsp_endpoint_handler* handler_;
-  // TODO(strager): Make this a pointer so we can avoid #include-ing
-  // <simdjson.h>.
-  ::simdjson::ondemand::parser json_parser_;
+  std::unique_ptr< ::simdjson::ondemand::parser> json_parser_;
 
   friend message_parser;
 };

src/quick-lint-js/simdjson-fwd.h

@@ -24,6 +24,7 @@ namespace QUICK_LINT_JS_SIMDJSON_IMPLEMENTATION_NAMESPACE {
 namespace ondemand {
 class array;
 class object;
+class parser;
 class value;
 }
 }