feat: set white background on readonly editor content

Like qtype_essay does.

Author: MHajoha

classes/local/attempt_ui/qpy_rich_text_editor.php

@@ -24,6 +24,7 @@
 use DOMNode;
 use DOMXPath;
 use file_exception;
+use html_writer;
 use Iterator;
 use moodle_exception;
 use moodle_url;
@@ -145,6 +146,7 @@ public static function from_element(DOMElement $element): ?static {
      * @throws stored_file_creation_exception
      */
     public function render(question_attempt $qa, question_ui_renderer $renderer): DOMNode {
+        $html = html_writer::start_div('qpy-editor-container ' . ($renderer->options->readonly ? 'readonly' : ''));
         if ($renderer->options->readonly) {
             global $PAGE;
             /** @var qtype_questionpy_renderer $qpyrenderer */
@@ -154,7 +156,7 @@ public function render(question_attempt $qa, question_ui_renderer $renderer): DO
             $editorsdata = utils::get_qpy_editors_data($responsestep->get_qt_data());
             $editordata = $editorsdata[$this->name] ?? null;
 
-            $html = $qpyrenderer->render_readonly_editor_content(
+            $html .= $qpyrenderer->render_readonly_editor_content(
                 $editordata,
                 qubaid: $qa->get_usage_id(),
                 slot: $qa->get_slot(),
@@ -164,24 +166,27 @@ public function render(question_attempt $qa, question_ui_renderer $renderer): DO
                 rows: $this->rows,
                 cols: $this->cols
             );
-            return dom_utils::html_to_fragment($this->element->ownerDocument, $html);
-        } {
-            return $this->render_writable($renderer, $qa);
+        } else {
+            $html .= $this->render_writable($renderer, $qa);
         }
+
+        $html .= html_writer::end_div();
+
+        return dom_utils::html_to_fragment($this->element->ownerDocument, $html);
     }
 
     /**
      * Renders an editor using the usual Moodle APIs.
      *
      * @param question_ui_renderer $renderer
      * @param question_attempt $qa
-     * @return DOMDocumentFragment|false|void
+     * @return string HTML
      * @throws coding_exception
      * @throws file_exception
      * @throws moodle_exception
      * @throws stored_file_creation_exception
      */
-    public function render_writable(question_ui_renderer $renderer, question_attempt $qa) {
+    public function render_writable(question_ui_renderer $renderer, question_attempt $qa): string {
         $limits = $this->get_limits_in($renderer->options->context);
 
         $alleditorsdata = utils::get_qpy_editors_data($qa);
@@ -241,7 +246,7 @@ public function render_writable(question_ui_renderer $renderer, question_attempt
 
         $meditor->setValue($values);
 
-        return dom_utils::html_to_fragment($this->element->ownerDocument, $meditor->toHtml());
+        return $meditor->toHtml();
     }
 
     /**

styles.css

@@ -60,6 +60,11 @@ body.questionpy-iframe-body {
     }
 }
 
+.qpy-editor-container.readonly {
+    /* Adopted from .que.essay .qtype_essay_response.readonly. */
+    background-color: var(--bs-white);
+}
+
 /* Make question iframe seamless. */
 body.questionpy-iframe-body .formulation {
     padding: 0;