Skip to content

Commit a9eadac

Browse files
authored
Merge pull request #12739 from quarto-dev/typst/brand-fix-heading
typst, template - remove non-valid brand.headings fields from typst template
2 parents dbfba01 + 7f41954 commit a9eadac

File tree

5 files changed

+3
-10
lines changed

5 files changed

+3
-10
lines changed

news/changelog-1.8.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ All changes included in 1.8:
2828
### `typst`
2929

3030
- ([#12554](https://github.com/quarto-dev/quarto-cli/pull/12554)): CSS properties `font-weight` and `font-style` are translated to Typst `text` properties.
31+
- ([#12739](https://github.com/quarto-dev/quarto-cli/pull/12739)): Remove unused variable `heading-background-color` and `heading-decoration` from Typst's templates. They are leftover from previous change, and not part of Brand.yml schema for typography of headings.
3132

3233
## Projects
3334

src/resources/create/extensions/format-typst/_extensions/qstart-filesafename-qend/typst-show.typ

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ $endif$
6969
$if(brand.typography.headings.style)$
7070
heading-style: "$brand.typography.headings.style$",
7171
$endif$
72-
$if(brand.typography.headings.decoration)$
73-
heading-decoration: "$brand.typography.headings.decoration$",
74-
$endif$
7572
$if(brand.typography.headings.color)$
7673
heading-color: $brand.typography.headings.color$,
7774
$endif$

src/resources/create/extensions/format-typst/_extensions/qstart-filesafename-qend/typst-template.typ

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@
5555
align(center)[#block(inset: 2em)[
5656
#set par(leading: heading-line-height)
5757
#if (heading-family != none or heading-weight != "bold" or heading-style != "normal"
58-
or heading-color != black or heading-decoration == "underline"
59-
or heading-background-color != none) {
58+
or heading-color != black) {
6059
set text(font: heading-family, weight: heading-weight, style: heading-style, fill: heading-color)
6160
text(size: title-size)[#title]
6261
if subtitle != none {

src/resources/formats/typst/pandoc/quarto/typst-show.typ

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ $endif$
5555
$if(brand.typography.headings.style)$
5656
heading-style: "$brand.typography.headings.style$",
5757
$endif$
58-
$if(brand.typography.headings.decoration)$
59-
heading-decoration: "$brand.typography.headings.decoration$",
60-
$endif$
6158
$if(brand.typography.headings.color)$
6259
heading-color: $brand.typography.headings.color$,
6360
$endif$

src/resources/formats/typst/pandoc/quarto/typst-template.typ

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@
4444
align(center)[#block(inset: 2em)[
4545
#set par(leading: heading-line-height)
4646
#if (heading-family != none or heading-weight != "bold" or heading-style != "normal"
47-
or heading-color != black or heading-decoration == "underline"
48-
or heading-background-color != none) {
47+
or heading-color != black) {
4948
set text(font: heading-family, weight: heading-weight, style: heading-style, fill: heading-color)
5049
text(size: title-size)[#title]
5150
if subtitle != none {

0 commit comments

Comments
 (0)