remove unneeded window globals

Author: gordonwoodhull

src/resources/formats/html/giscus/giscus.ejs

@@ -22,7 +22,7 @@
           if(giscusIframe) {
             giscusIframe.addEventListener("load", function() {
               window.setTimeout(() => {
-                window.toggleGiscusIfUsed(window.hasAlternateSentinel(), authorPrefersDark);
+                toggleGiscusIfUsed(hasAlternateSentinel(), authorPrefersDark);
               }, 100);
             });
             giscusIframeObserver.disconnect();

src/resources/formats/html/templates/quarto-html-after-body.ejs

@@ -22,7 +22,7 @@
   
       window.document.body.appendChild(a);
     }
-    window.setColorSchemeToggle(window.hasAlternateSentinel())
+    setColorSchemeToggle(hasAlternateSentinel())
 
     <% } %>
   

src/resources/formats/html/templates/quarto-html-before-body.ejs

@@ -21,7 +21,7 @@
       }
     }
 
-    window.setColorSchemeToggle = (alternate) => {
+    const setColorSchemeToggle = (alternate) => {
       const toggles = window.document.querySelectorAll('.quarto-color-scheme-toggle');
       for (let i=0; i < toggles.length; i++) {
         const toggle = toggles[i];
@@ -56,7 +56,7 @@
       manageTransitions('#quarto-margin-sidebar .nav-link', true);
 
       // Switch the toggles
-      window.setColorSchemeToggle(alternate)
+      setColorSchemeToggle(alternate)
 
       // Hack to workaround the fact that safari doesn't
       // properly recolor the scrollbar when toggling (#1455)
@@ -103,7 +103,7 @@
       return window.location.protocol === 'file:';
     }
 
-    window.hasAlternateSentinel = () => {
+    const hasAlternateSentinel = () => {
       let styleSentinel = getColorSchemeSentinel();
       if (styleSentinel !== null) {
         return styleSentinel === "alternate";
@@ -182,14 +182,12 @@
     // Dark / light mode switch
     window.quartoToggleColorScheme = () => {
       // Read the current dark / light value
-      let toAlternate = !window.hasAlternateSentinel();
+      let toAlternate = !hasAlternateSentinel();
       toggleColorMode(toAlternate);
       setStyleSentinel(toAlternate);
       toggleGiscusIfUsed(toAlternate, darkModeDefault);
     };
 
-    window.toggleGiscusIfUsed = toggleGiscusIfUsed;
-
     <% if (respectUserColorScheme) { %>
     queryPrefersDark.addEventListener("change", e => {
       if(window.localStorage.getItem("quarto-color-scheme") !== null)
@@ -202,7 +200,7 @@
     <% } %>
 
     // Switch to dark mode if need be
-    if (window.hasAlternateSentinel()) {
+    if (hasAlternateSentinel()) {
       toggleColorMode(true);
     } else {
       toggleColorMode(false);