Merge pull request #13441 from quarto-dev/bugfix/render-failure-exception-forwarding

restore 1.7 behavior on invalid exception percolating

Author: cscheid

news/changelog-1.9.md

@@ -3,6 +3,7 @@ All changes included in 1.9:
 ## Regression fixes
 
 - ([#13396](https://github.com/quarto-dev/quarto-cli/issues/13396)): Fix `quarto publish connect` regression.
+- ([#13441](https://github.com/quarto-dev/quarto-cli/pull/13441)): Catch `undefined` exceptions in Pandoc failure to avoid spurious error message.
 
 ## Dependencies
 

src/command/render/render-files.ts

@@ -352,12 +352,13 @@ export async function renderFiles(
     return await pandocRenderer.onComplete(false, options.flags?.quiet);
   } catch (error) {
     if (!(error instanceof Error)) {
-      warn("Should not have arrived here:", error);
-      throw error;
+      warn(`Error encountered when rendering files`);
     }
     return {
       files: (await pandocRenderer.onComplete(true)).files,
-      error: error || new Error(),
+      error: error instanceof Error
+        ? error
+        : new Error(error ? String(error) : undefined),
     };
   } finally {
     tempContext.cleanup();
@@ -409,12 +410,13 @@ export async function renderFile(
     return await pandocRenderer.onComplete(false, options.flags?.quiet);
   } catch (error) {
     if (!(error instanceof Error)) {
-      warn("Should not have arrived here:", error);
-      throw error;
+      warn(`Error encountered when rendering ${file.path}`);
     }
     return {
       files: (await pandocRenderer.onComplete(true)).files,
-      error: error || new Error(),
+      error: error instanceof Error
+        ? error
+        : new Error(error ? String(error) : undefined),
     };
   } finally {
     if (Deno.env.get("QUARTO_PROFILER_OUTPUT")) {