Merge pull request #12967 from quarto-dev/workbench-no-open

create - force `--no-open` when inside Posit  Workbench

Author: cderv

news/changelog-1.8.md

@@ -79,6 +79,10 @@ All changes included in 1.8:
 
 - ([#12627](https://github.com/quarto-dev/quarto-cli/issues/12627)): Don't actually install extension when user responds `yes` to first prompt but `no` to second.
 
+### `create`
+
+- ([#12965](https://github.com/quarto-dev/quarto-cli/issues/12965)): Prevent automatic opening of new editor sessions when creating projects in Posit Workbench context. The `--open` flag is now ignored in this environment to avoid issues with Workbench session management.
+
 ## Engines
 
 ### `jupyter`

src/command/create/cmd.ts

@@ -8,7 +8,10 @@ import { extensionArtifactCreator } from "./artifacts/extension.ts";
 import { projectArtifactCreator } from "./artifacts/project.ts";
 import { kEditorInfos, scanForEditors } from "./editor.ts";
 
-import { isInteractiveTerminal } from "../../core/platform.ts";
+import {
+  isInteractiveTerminal,
+  isPositWorkbench,
+} from "../../core/platform.ts";
 import { runningInCI } from "../../core/ci-info.ts";
 
 import { Command } from "cliffy/command/mod.ts";
@@ -56,6 +59,16 @@ export const createCommand = new Command()
         const isInteractive = isInteractiveTerminal() && !runningInCI();
         const allowPrompt = isInteractive && !!options.prompt && !options.json;
 
+        // Specific case where opening automatically in an editor is not allowed
+        if (options.open !== false && isPositWorkbench()) {
+          if (options.open !== undefined) {
+            info(
+              `The --open option is not supported in Posit Workbench - ignoring`,
+            );
+          }
+          options.open = false;
+        }
+
         // Resolve the type into an artifact
         const resolved = await resolveArtifact(
           type,

src/command/preview/preview.ts

@@ -76,8 +76,8 @@ import {
   safeExistsSync,
 } from "../../core/path.ts";
 import {
+  isPositWorkbench,
   isRStudio,
-  isRStudioWorkbench,
   isServerSession,
   isVSCodeServer,
   vsCodeServerProxyUri,
@@ -872,7 +872,7 @@ function pdfFileRequestHandler(
     const onRequest = pdfOptions.onRequest;
     pdfOptions.onRequest = async (req: Request) => {
       if (new URL(req.url).pathname === "/") {
-        const url = isRStudioWorkbench()
+        const url = isPositWorkbench()
           ? await rswURL(port, kPdfJsInitialPath)
           : isVSCodeServer()
           ? vsCodeServerProxyUri()!.replace("{{port}}", `${port}`) +

src/core/platform.ts

@@ -34,7 +34,7 @@ export function isVSCodeServer() {
   return !!vsCodeServerProxyUri();
 }
 
-export function isRStudioWorkbench() {
+export function isPositWorkbench() {
   // RS_SERVER_URL e.g. https://daily-rsw.soleng.rstudioservices.com/
   // RS_SESSION_URL e.g. /s/eae053c9ab5a71168ee19/
   return !!Deno.env.get("RS_SERVER_URL") && !!Deno.env.get("RS_SESSION_URL");
@@ -50,7 +50,7 @@ export function isPositronTerminal() {
 }
 
 export function isServerSession() {
-  return isRStudioServer() || isRStudioWorkbench() || isJupyterServer() ||
+  return isRStudioServer() || isPositWorkbench() || isJupyterServer() ||
     isJupyterHubServer() || isVSCodeServer();
 }
 

src/core/previewurl.ts

@@ -10,8 +10,8 @@ import * as colors from "fmt/colors";
 import {
   isJupyterHubServer,
   isJupyterServer,
+  isPositWorkbench,
   isRStudioServer,
-  isRStudioWorkbench,
   isVSCodeServer,
   isVSCodeTerminal,
   jupyterHubHttpReferrer,
@@ -58,7 +58,7 @@ export async function printBrowsePreviewMessage(
   path: string,
 ) {
   if (
-    (isJupyterServer() || isVSCodeTerminal()) && isRStudioWorkbench()
+    (isJupyterServer() || isVSCodeTerminal()) && isPositWorkbench()
   ) {
     const url = await rswURL(port, path);
     info(`\nPreview server: ${previewURL(host, port, path = "")}`);