refactor: make script posix compatible

Author: qoomon

aws-ssm-ssh-proxy-command.sh

@@ -13,10 +13,10 @@ ssh_port="$3"
 ssh_public_key_path="$4"
 
 REGION_SEPARATOR='--'
-if [[ "${instance_id}" == *"${REGION_SEPARATOR}"* ]]
+if echo "$instance_id" | grep -q -e "${REGION_SEPARATOR}" 
 then
-  export AWS_DEFAULT_REGION="${instance_id##*${REGION_SEPARATOR}}"
-  instance_id="${instance_id%%${REGION_SEPARATOR}*}"
+  export AWS_DEFAULT_REGION="${instance_id##*"${REGION_SEPARATOR}"}"
+  instance_id="${instance_id%%"$REGION_SEPARATOR"*}"
 fi
 
 >/dev/stderr echo "Add public key ${ssh_public_key_path} for ${ssh_user} at instance ${instance_id} for 10 seconds"

aws-ssm-ssh-proxy-command_start-ec2-instance.sh

@@ -4,33 +4,33 @@ set -eu
 instance_id="$1"
 
 REGION_SEPARATOR='--'
-if [[ "${instance_id}" == *"${REGION_SEPARATOR}"* ]]
+if echo "$instance_id" | grep -q -e "${REGION_SEPARATOR}" 
 then
-  export AWS_DEFAULT_REGION="${instance_id##*${REGION_SEPARATOR}}"
-  instance_id="${instance_id%%${REGION_SEPARATOR}*}"
+  export AWS_DEFAULT_REGION="${instance_id##*"$REGION_SEPARATOR"}"
+  instance_id="${instance_id%%"$REGION_SEPARATOR"*}"
 fi
 
 START_INSTANCE_TIMEOUT=300
 START_INSTANCE_CHECK_INTERVAL=5
-STATUS=`aws ssm describe-instance-information --filters Key=InstanceIds,Values=${instance_id} --output text --query 'InstanceInformationList[0].PingStatus'`
-if [ $STATUS != 'Online' ]
+STATUS=$(aws ssm describe-instance-information --filters Key=InstanceIds,Values="$instance_id" --output text --query 'InstanceInformationList[0].PingStatus')
+if [ "$STATUS" != 'Online' ]
 then
   aws ec2 start-instances --instance-ids "${instance_id}" --profile "${AWS_PROFILE}" --region "${AWS_REGION}"
   >/dev/stderr echo "Waiting for EC2 Instance ${instance_id}..."
   START_INSTANCE_START="$(date +%s)"
-  while [ $(( $(date +%s) - $START_INSTANCE_START)) -le ${START_INSTANCE_TIMEOUT} ]
+  while [ $(( $(date +%s) - "$START_INSTANCE_START")) -le ${START_INSTANCE_TIMEOUT} ]
   do
-      >/dev/stderr echo -n "."
+      >/dev/stderr printf "."
       sleep ${START_INSTANCE_CHECK_INTERVAL}
-      STATUS=`aws ssm describe-instance-information --filters Key=InstanceIds,Values=${instance_id} --output text --query 'InstanceInformationList[0].PingStatus'`
-      if [ ${STATUS} == 'Online' ]
+      STATUS=$(aws ssm describe-instance-information --filters Key=InstanceIds,Values="$instance_id" --output text --query 'InstanceInformationList[0].PingStatus')
+      if [ "$STATUS" = 'Online' ]
       then
           break
       fi
   done
   >/dev/stderr echo
 
-  if [ $STATUS != 'Online' ]
+  if [ "$STATUS" != 'Online' ]
   then
       >/dev/stderr echo "Timeout."
       exit 1

ec2-instance-connect/aws-ssm-ssh-proxy-command.sh

@@ -13,10 +13,10 @@ ssh_port="$3"
 ssh_public_key_path="$4"
 
 REGION_SEPARATOR='--'
-if [[ "${instance_id}" == *"${REGION_SEPARATOR}"* ]]
+if echo "$instance_id" | grep -q -e "${REGION_SEPARATOR}"
 then
-  export AWS_DEFAULT_REGION="${instance_id##*${REGION_SEPARATOR}}"
-  instance_id="${instance_id%%${REGION_SEPARATOR}*}"
+  export AWS_DEFAULT_REGION="${instance_id##*"$REGION_SEPARATOR"}"
+  instance_id="${instance_id%%"$REGION_SEPARATOR"*}"
 fi
 
 >/dev/stderr echo "Add public key ${ssh_public_key_path} for ${ssh_user} at instance ${instance_id} for 60 seconds"