Merge pull request #135 from netroby/feature/strict-check-request

Strict check in Response.php; efficient optimize

Author: longbai

src/Qiniu/Http/Response.php

@@ -84,11 +84,11 @@ public function __construct($code, $duration, array $headers = array(), $body =
         $this->body = $body;
         $this->error = $error;
         $this->jsonData = null;
-        if ($error != null) {
+        if ($error !== null) {
             return;
         }
 
-        if ($body == null) {
+        if ($body === null) {
             if ($code >= 400) {
                 $this->error = self::$statusTexts[$code];
             }
@@ -98,18 +98,16 @@ public function __construct($code, $duration, array $headers = array(), $body =
             try {
                 $jsonData = self::bodyJson($body);
                 if ($code >=400) {
-                    if ($jsonData['error'] != null) {
+                    $this->error = $body;
+                    if ($jsonData['error'] !== null) {
                         $this->error = $jsonData['error'];
-                    } else {
-                        $this->error = $body;
                     }
                 }
                 $this->jsonData = $jsonData;
             } catch (\InvalidArgumentException $e) {
+                $this->error = $body;
                 if ($code >= 200 && $code < 300) {
                     $this->error = $e->getMessage();
-                } else {
-                    $this->error = $body;
                 }
             }
         } elseif ($code >=400) {
@@ -127,19 +125,19 @@ private static function bodyJson($body, array $config = array())
     {
         return \Qiniu\json_decode(
             (string) $body,
-            isset($config['object']) ? !$config['object'] : true,
+            array_key_exists('object', $config) ? !$config['object'] : true,
             512,
-            isset($config['big_int_strings']) ? JSON_BIGINT_AS_STRING : 0
+            array_key_exists('big_int_strings', $config) ? JSON_BIGINT_AS_STRING : 0
         );
     }
 
     public function xVia()
     {
         $via = $this->headers['X-Via'];
-        if ($via == null) {
+        if ($via === null) {
             $via = $this->headers['X-Px'];
         }
-        if ($via == null) {
+        if ($via === null) {
             $via = $this->headers['Fw-Via'];
         }
         return $via;
@@ -157,20 +155,20 @@ public function xReqId()
 
     public function ok()
     {
-        return $this->statusCode >= 200 && $this->statusCode < 300 && $this->error == null;
+        return $this->statusCode >= 200 && $this->statusCode < 300 && $this->error === null;
     }
 
     public function needRetry()
     {
         $code = $this->statusCode;
-        if ($code< 0 || ($code / 100 == 5 and $code != 579) || $code == 996) {
+        if ($code< 0 || ($code / 100 === 5 and $code !== 579) || $code === 996) {
             return true;
         }
     }
 
     private static function isJson($headers)
     {
-        return isset($headers['Content-Type']) &&
+        return array_key_exists('Content-Type', $headers) &&
         strpos($headers['Content-Type'], 'application/json') === 0;
     }
 }