Skip to content

fix: resolve data race in uptoken.NewSigner #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve data race in uptoken.NewSigner #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions storagev2/uptoken/uploadtoken.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ type (
putPolicy PutPolicy
credentialsProvider credentials.CredentialsProvider
onceCredentials sync.Once
onceUpToken sync.Once
upToken string
credentials *credentials.Credentials
}
Expand Down Expand Up @@ -86,19 +87,20 @@ func (signer *signer) onceGetCredentials(ctx context.Context) (*credentials.Cred

func (signer *signer) onceGetUpToken(ctx context.Context) (string, error) {
var err error
if signer.upToken != "" {
return signer.upToken, nil
}
credentials, err := signer.onceGetCredentials(ctx)
if err != nil {
return "", nil
}
putPolicyJson, err := json.Marshal(signer.putPolicy)
if err != nil {
return "", nil
}
signer.upToken = credentials.SignWithData(putPolicyJson)
return signer.upToken, nil
signer.onceUpToken.Do(func() {
var credentials *credentials.Credentials
credentials, err = signer.onceGetCredentials(ctx)
if err != nil {
return
}
var putPolicyJson []byte
putPolicyJson, err = json.Marshal(signer.putPolicy)
if err != nil {
return
}
signer.upToken = credentials.SignWithData(putPolicyJson)
})
return signer.upToken, err
}

// NewParser 创建上传凭证签发器
Expand Down
Loading