fix: resolve data race in uptoken.NewSigner #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @zhangzqs
Summary
Fixed a critical thread-safety issue in the
storagev2/uptokenpackage where concurrent calls toGetUpToken()caused data races during parallel file uploads.Problem
The data race detector identified concurrent read/write operations on
signer.upTokenfield:if signer.upToken != ""signer.upToken = credentials.SignWithData(putPolicyJson)When multiple goroutines called
GetUpToken()simultaneously (e.g., duringUploadDirectoryoperations), they would:upTokenfieldSolution
Implemented thread-safe token initialization using
sync.Once:onceUpToken sync.Oncefield to thesignerstructonceGetUpToken()to usesync.Once.Do()for initializationThe fix follows the same pattern already used in
onceGetCredentials()method, maintaining consistency with the existing codebase.Testing
The original issue was detected during concurrent upload operations in
UploadDirectory. This fix ensures that:Fixes #169
Generated with codeagent