fixed #8

Author: s-m-e

i18n/qgist_de.ts

@@ -59,6 +59,7 @@
     WORKBENCH_WIDGET_WIDTH,
     )
 from .dtype_fsm import dtype_fsm_class
+from .error import QgistUnnamedElementError
 from .ui_manager import ui_manager_class
 from ..config import (
     config_class,
@@ -278,6 +279,6 @@ def _save_workbench(self):
 
         try:
             self._fsm.save_workbench(self._fsm.active_workbench, self._mainwindow)
-        except Qgist_ALL_Errors as e:
+        except Qgist_ALL_Errors + (QgistUnnamedElementError,) as e:
             msg_critical(e, self._mainwindow)
             return

i18n/qgist_en.ts

@@ -72,7 +72,7 @@ def __init__(self, workbench_list, mainwindow, active_workbench = None, config =
         self._config = config
 
         self._workbench_dict = {
-            item['name']: dtype_workbench_class(mainwindow = mainwindow, **item)
+            item['name']: dtype_workbench_class(mainwindow = mainwindow, config = self._config, **item)
             for item in workbench_list
             }
         if active_workbench is not None and active_workbench not in self._workbench_dict.keys():
@@ -135,7 +135,11 @@ def new_workbench(self, name, mainwindow):
         if len(name) == 0:
             raise QgistWorkbenchNameError(translate('global', '"name" is empty. (dtype_fsm new)'))
 
-        self._workbench_dict[name] = dtype_workbench_class.from_mainwindow(name, mainwindow)
+        self._workbench_dict[name] = dtype_workbench_class.from_mainwindow(
+            name = name,
+            mainwindow = mainwindow,
+            config = self._config,
+            )
         self._active_workbench = name
 
         self._update_config()
@@ -215,3 +219,13 @@ def active_workbench(self):
     def active_workbench(self, value):
 
         raise QgistAttributeError(translate('global', '"active_workbench" must not be changed. (dtype_fsm active)'))
+
+    @property
+    def config(self):
+
+        return self._config
+
+    @config.setter
+    def config(self, value):
+
+        raise QgistAttributeError(translate('global', '"config" must not be changed. (dtype_fsm config)'))

qgist/workbench/core.py

@@ -38,6 +38,7 @@
 # IMPORT (Internal)
 # +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
+from .error import QgistUnnamedElementError
 from ..error import (
     QgistAttributeError,
     QgistTypeError,
@@ -62,7 +63,7 @@ def __init__(self,
         if not isinstance(name_internal, str):
             raise QgistTypeError(translate('global', '"internal_name" must be str. (dtype_uielement)'))
         if len(name_internal) == 0:
-            raise QgistValueError(translate('global', 'Unnamed UI element. (dtype_uielement)'))
+            raise QgistUnnamedElementError(translate('global', 'Unnamed UI element. (dtype_uielement)'))
         self._name_internal = name_internal
 
         if not isinstance(name_translated, str):

qgist/workbench/dtype_fsm.py

@@ -47,6 +47,8 @@
 # +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
 from .dtype_uielement import dtype_uielement_class
+from .error import QgistUnnamedElementError
+from ..config import config_class
 from ..error import (
     QgistTypeError,
     QgistValueError,
@@ -68,8 +70,14 @@ def __init__(self,
         toolbars_list = None,
         dockwidgets_list = None,
         mainwindow = None,
+        config = None,
         ):
 
+        if not isinstance(config, config_class) and config is not None:
+            raise QgistTypeError(translate('global', '"config" must be a "config_class" object or None. (dtype_workbench)'))
+
+        self._config = config
+
         if not isinstance(name, str):
             raise QgistTypeError(translate('global', '"name" must be str. (dtype_workbench)'))
         if len(name) == 0:
@@ -144,8 +152,18 @@ def activate(self, mainwindow):
         qtoolbars_dict = dtype_workbench_class._get_uielements_from_mainwindow(mainwindow, QToolBar)
         qdockwidgets_dict = dtype_workbench_class._get_uielements_from_mainwindow(mainwindow, QDockWidget)
 
-        dtype_workbench_class._activate_uielements(qtoolbars_dict, self._toolbars_dict)
-        dtype_workbench_class._activate_uielements(qdockwidgets_dict, self._dockwidgets_dict)
+        show_unnamed_warning = False if self._config is None else self._config.get('show_unnamed_warning', False)
+
+        dtype_workbench_class._activate_uielements(
+            uiobjects_dict = qtoolbars_dict,
+            uielements_dict = self._toolbars_dict,
+            show_unnamed_warning = show_unnamed_warning,
+            )
+        dtype_workbench_class._activate_uielements(
+            uiobjects_dict = qdockwidgets_dict,
+            uielements_dict = self._dockwidgets_dict,
+            show_unnamed_warning = show_unnamed_warning,
+            )
 
         mainwindow.restoreState(self._mainwindow_state)
 
@@ -180,7 +198,7 @@ def toolbars(self):
         return (self._toolbars_dict[name] for name in sorted(self.toolbars_keys()))
 
     @staticmethod
-    def _activate_uielements(uiobjects_dict, uielements_dict):
+    def _activate_uielements(uiobjects_dict, uielements_dict, show_unnamed_warning):
 
         for name_internal, uiobject in uiobjects_dict.items():
             if name_internal in uielements_dict.keys():
@@ -191,6 +209,11 @@ def _activate_uielements(uiobjects_dict, uielements_dict):
                 try:
                     uielement = dtype_uielement_class.from_uiobject(uiobject)
                     uielements_dict[uielement.name_internal] = uielement
+                except QgistUnnamedElementError as e:
+                    """implementing #8, enabling the user to disable warnings
+                    which are mainly caused by other plugins"""
+                    if show_unnamed_warning:
+                        msg_warning(e)
                 except Qgist_ALL_Errors as e:
                     msg_warning(e)
         for name_internal in (uielements_dict.keys() - uiobjects_dict.keys()):
@@ -243,10 +266,14 @@ def name(self, value):
     def from_mainwindow(
         name = '',
         mainwindow = None,
+        config = None,
         ):
 
+        # name is checked by dtype_workbench_class.__init__
         if not isinstance(mainwindow, QMainWindow):
             raise QgistTypeError(translate('global', '"mainwindow" must be a QGIS mainwindow. (dtype_workbench from_mainwindow)'))
+        if not isinstance(config, config_class) and config is not None:
+            raise QgistTypeError(translate('global', '"config" must be a "config_class" object or None. (dtype_workbench from_mainwindow)'))
 
         toolbars_list = [
             dtype_uielement_class.from_uiobject(uiobject).as_dict()
@@ -270,4 +297,5 @@ def from_mainwindow(
             toolbars_list = toolbars_list,
             dockwidgets_list = dockwidgets_list,
             mainwindow = mainwindow,
+            config = config,
             )

qgist/workbench/dtype_uielement.py

@@ -28,5 +28,8 @@
 # EXCEPTIONS
 # +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
+class QgistUnnamedElementError(Exception):
+    pass
+
 class QgistWorkbenchNameError(Exception):
     pass

qgist/workbench/dtype_workbench.py

@@ -110,6 +110,16 @@ def _connect_ui(self):
         self._update_workbenches()
         self._uptdate_items()
 
+        if self._fsm.config is None:
+            self._ui_dict['checkbox_unnamedwarning'].setEnabled(False)
+        else:
+            self._ui_dict['checkbox_unnamedwarning'].setCheckState(
+                Qt.Checked if self._fsm.config.get('show_unnamed_warning', False) else Qt.Unchecked
+                )
+            def change_unnamedwarning():
+                self._fsm.config['show_unnamed_warning'] = bool(self._ui_dict['checkbox_unnamedwarning'].isChecked())
+            self._ui_dict['checkbox_unnamedwarning'].stateChanged.connect(change_unnamedwarning)
+
     def _list_workbenches_currentrowchanged(self):
 
         if not bool(self._ui_dict['list_workbenches'].isEnabled()):

qgist/workbench/error.py

@@ -43,6 +43,7 @@
     QIcon,
     )
 from PyQt5.QtWidgets import (
+    QCheckBox,
     QDialog,
     QHBoxLayout,
     QLabel,
@@ -127,6 +128,9 @@ def _init_dialogtoolbar(ui_dict, toolbar_layout, plugin_root_fld):
 
         toolbar_layout.addStretch()
 
+        ui_dict['checkbox_unnamedwarning'] = QCheckBox(translate('global', 'Warn if UI elements can not be uniquely identified'))
+        toolbar_layout.addWidget(ui_dict['checkbox_unnamedwarning'])
+
     @staticmethod
     def _get_workbenchlist():