Skip to content

Commit 077d41d

Browse files
committed
fixed #7
1 parent 78219b1 commit 077d41d

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 0.0.2 (2019-XX-XX)
44

55
* Fixed #6: `workbench` does not crash anymore when certain other plugins are loaded. Background: Their UI exposes its Qt parent as a property instead of a method.
6+
* Fixed #7: `workbench` can start even of other plugins contain unnamed UI elements.
67

78
## 0.0.1 (2019-09-01)
89

qgist/workbench/dtype_workbench.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@
5050
from ..error import (
5151
QgistTypeError,
5252
QgistValueError,
53+
Qgist_ALL_Errors,
5354
)
55+
from ..msg import msg_warning
5456
from ..util import translate
5557

5658

@@ -181,11 +183,16 @@ def toolbars(self):
181183
def _activate_uielements(uiobjects_dict, uielements_dict):
182184

183185
for name_internal, uiobject in uiobjects_dict.items():
184-
try:
186+
if name_internal in uielements_dict.keys():
185187
uielements_dict[name_internal].push_state_to_uiobject()
186-
except KeyError:
187-
uielement = dtype_uielement_class.from_uiobject(uiobject)
188-
uielements_dict[uielement.name_internal] = uielement
188+
else:
189+
"""try/except-block fixes #7, Certain other plugins inhibit
190+
the start of Workbench because of unnamed UI elements"""
191+
try:
192+
uielement = dtype_uielement_class.from_uiobject(uiobject)
193+
uielements_dict[uielement.name_internal] = uielement
194+
except Qgist_ALL_Errors as e:
195+
msg_warning(e)
189196
for name_internal in (uielements_dict.keys() - uiobjects_dict.keys()):
190197
uielements_dict[name_internal].existence = False
191198

0 commit comments

Comments
 (0)