fixed #1 ui allows to rename workbenches

Author: s-m-e

qgist/workbench/dtype_fsm.py

@@ -172,11 +172,11 @@ def rename_workbench(self, old_name, new_name, mainwindow):
         if not isinstance(mainwindow, QMainWindow):
             raise QgistTypeError(translate('global', '"mainwindow" must be a QGis mainwindow. (dtype_fsm rename)'))
         if old_name not in self._workbench_dict.keys():
-            raise QgistValueError(translate('global', '"old_name" is not a known workbench. (dtype_fsm rename)'))
+            raise QgistWorkbenchNameError(translate('global', '"old_name" is not a known workbench. (dtype_fsm rename)'))
         if new_name in self._workbench_dict.keys():
-            raise QgistValueError(translate('global', '"new_name" is a known workbench, i.e. already exists. (dtype_fsm rename)'))
+            raise QgistWorkbenchNameError(translate('global', '"new_name" is a known workbench, i.e. already exists. (dtype_fsm rename)'))
         if len(new_name) == 0:
-            raise QgistValueError(translate('global', '"new_name" is empty. (dtype_fsm rename)'))
+            raise QgistWorkbenchNameError(translate('global', '"new_name" is empty. (dtype_fsm rename)'))
         if old_name == new_name:
             return
 

qgist/workbench/dtype_workbench.py

@@ -255,9 +255,9 @@ def name(self):
     @name.setter
     def name(self, value):
 
-        if not isinstance(name, str):
+        if not isinstance(value, str):
             raise QgistTypeError(translate('global', 'New value of "name" must be a str. (dtype_workbench name)'))
-        if len(name) == 0:
+        if len(value) == 0:
             raise QgistValueError(translate('global', 'New value of "name" must not be empty. (dtype_workbench name)'))
 
         self._name = value

qgist/workbench/ui_manager.py

@@ -100,7 +100,7 @@ def __init__(self, plugin_root_fld, mainwindow, combobox_workbench, combobox_wor
 
     def _connect_ui(self):
 
-        for item in ('new', 'delete', 'save'):
+        for item in ('new', 'delete', 'save', 'rename'):
             self._ui_dict['toolbutton_{NAME:s}'.format(NAME = item)].clicked.connect(
                 getattr(self, '_toolbutton_{NAME:s}_clicked'.format(NAME = item))
                 )
@@ -187,6 +187,30 @@ def _toolbutton_save_clicked(self):
             self.reject()
             return
 
+    def _toolbutton_rename_clicked(self):
+
+        old_name = self._workbench_index_to_name(self._ui_dict['list_workbenches'].currentRow())
+        new_name, user_ok = QInputDialog.getText(
+            self,
+            translate('global', 'Rename workbench'),
+            translate('global', 'New name of workbench')
+            )
+
+        if not user_ok:
+            return
+
+        try:
+            self._fsm.rename_workbench(old_name, new_name, self._mainwindow)
+            self._update_workbenches()
+            self._uptdate_items()
+        except QgistWorkbenchNameError as e:
+            msg_warning(e, self)
+            return
+        except Qgist_ALL_Errors as e:
+            msg_critical(e, self)
+            self.reject()
+            return
+
     def _update_workbenches(self):
 
         self._ui_dict['list_workbenches'].setEnabled(False)