Revise solution for wait_for_new_window_open_async (#39)

Author: atthaboon

Examples/browser-demo.robot

@@ -11,9 +11,8 @@ Example switch window and check window title
     Maximize Browser Window
     ${title} =   Get title
     ${location} =   Get location
-    ${window count} =    Get Window Count
     Run Async Keywords
-    ...    Wait for new window open    ${window count}    5s    AND
+    ...    Wait for new window open    5s    AND
     ...    Click Element    id=readdocs
     Switch Window   NEW
     ${Title} =   Get Title

Examples/timeout-demo.robot

@@ -11,13 +11,12 @@ ${HOME_PAGE_URL}    http://127.0.0.1:7272
 *** Test Cases ***
 Set default timeout
     Set Timeout    3s
-    ${window count} =    Get Window Count
-    Run Keyword And Expect Error    No new page has been open.*    Wait for new window open    ${window count}
+    Run Keyword And Expect Error    No new page has been open.*    Wait for new window open
 
 Timeout wait for new window open
     ${window count} =    Get Window Count
     Run Async Keywords
-    ...    Wait for new window open    ${window count}    5s    AND    
+    ...    Wait for new window open    5s    AND    
     ...    Click Element    id:readdocs
 
 *** Keywords ***

PuppeteerLibrary/keywords/browsermanagement.py

@@ -164,7 +164,7 @@ def get_window_count(self):
         return  self.loop.run_until_complete(self.async_func.get_window_count_async())
 
     @keyword
-    def wait_for_new_window_open(self, current_page_count=1, timeout=None):
+    def wait_for_new_window_open(self, timeout=None):
         """
         Waits until new page or tab opens.
 
@@ -173,7 +173,7 @@ def wait_for_new_window_open(self, current_page_count=1, timeout=None):
         | Run Async Keywords | Click Element              | id:view_conditions          | AND  |
         | ...                | `Wait For New Window Open` |                             |      |
         """
-        self.loop.run_until_complete(self.async_func.wait_for_new_window_open_async(current_page_count, timeout))
+        self.loop.run_until_complete(self.async_func.wait_for_new_window_open_async(timeout))
 
     @keyword
     def switch_window(self, locator='MAIN'):

PuppeteerLibrary/keywords/browsermanagement_async.py

@@ -10,13 +10,17 @@ class BrowserManagementKeywordsAsync(LibraryComponent):
     async def get_window_count_async(self):
         pages = await self.ctx.get_browser().pages()
         for page in pages:
-            await page.title()  # workaround for force pages re-cache
+            # Workaround: for force pages re-cache
+            await page.title()
         return len(await self.ctx.get_browser().pages())
 
     @keyword
-    async def wait_for_new_window_open_async(self, current_page_count=1, timeout=None):
+    async def wait_for_new_window_open_async(self, timeout=None):
         page_len = 0
-        pre_page_len = int(current_page_count)
+        # Workaround:
+        # We get length without force reset. For ensure that when we count page length.
+        # Page length still not update / same as before open new window
+        pre_page_len = len(await self.ctx.get_browser().pages())
         timeout = self.timestr_to_secs_for_default_timeout(timeout)
         timer = 0
         while timer < timeout: