QA-7710: app update node address method

Author: Mikhail Podtserkovskiy

pool/mocks.go

@@ -72,3 +72,8 @@ func (s *StrategyListMock) FixNodeStatus(node Node) error {
 	args := s.Called(node)
 	return args.Error(0)
 }
+
+func (s *StorageMock) UpdateAddress(node Node, newAddress string) error {
+	args := s.Called(node, newAddress)
+	return args.Error(0)
+}

pool/pool.go

@@ -25,6 +25,7 @@ type StorageInterface interface {
 	GetByAddress(string) (Node, error)
 	GetAll() ([]Node, error)
 	Remove(Node) error
+	UpdateAddress(node Node, newAddress string) error
 }
 
 type StrategyInterface interface {

storage/local/local_test.go

@@ -149,3 +149,21 @@ func TestStorage_Remove_Negative(t *testing.T) {
 	err := s.Remove(node)
 	assert.Error(t, err, storage.ErrNotFound)
 }
+
+func TestStorage_UpdateAddress_UpdatesValue(t *testing.T) {
+	key := "1234567890"
+	node := pool.Node{Address: "1", Key: key}
+	s := Storage{db: map[string]*pool.Node{key: &node}}
+	expectedAddress := "2"
+	err := s.UpdateAddress(node, expectedAddress)
+	assert.NoError(t, err)
+	assert.Equal(t, expectedAddress, s.db[key].Address)
+}
+
+func TestStorage_UpdateAddress_ReturnsErrNotFound(t *testing.T) {
+	key := "1234567890"
+	node := pool.Node{Address: "1", Key: key}
+	s := Storage{db: map[string]*pool.Node{key: &node}}
+	err := s.UpdateAddress(pool.Node{Key:"12345"}, "1234567890")
+	assert.Equal(t, storage.ErrNotFound, err)
+}

storage/local/storage.go

@@ -129,3 +129,14 @@ func (s *Storage) Remove(node pool.Node) error {
 	delete(s.db, node.Key)
 	return nil
 }
+
+func (s *Storage) UpdateAddress(node pool.Node, newAddress string) error {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+	storedNode, ok := s.db[node.Key]
+	if !ok {
+		return storage.ErrNotFound
+	}
+	storedNode.Address = newAddress
+	return nil
+}

storage/mysql/storage.go

@@ -333,6 +333,27 @@ func (s *MysqlStorage) Remove(node pool.Node) error {
 	return nil
 }
 
+func (s *MysqlStorage) UpdateAddress(node pool.Node, newAddress string) error {
+	res, err := s.db.Exec(
+		"UPDATE node SET address = ? WHERE `key` = ?",
+		newAddress,
+		node.Key,
+	)
+	if err != nil {
+		err = errors.New("[MysqlStorage/UpdateAddress] update table `node`, " + err.Error())
+		return err
+	}
+	rowsAffected, err := res.RowsAffected()
+	if err != nil {
+		err = errors.New("[MysqlStorage/UpdateAddress] get affected rows, " + err.Error())
+		return err
+	}
+	if rowsAffected == 0 {
+		return storage.ErrNotFound
+	}
+	return nil
+}
+
 func mapper(model *MysqlNodeModel) *pool.Node {
 	node := pool.NewNode(
 		model.Key,

storage/tests/comon_test.go

@@ -1,6 +1,7 @@
 package tests
 
 import (
+	storageLib "github.com/qa-dev/jsonwire-grid/storage"
 	"github.com/qa-dev/jsonwire-grid/pool"
 	"github.com/qa-dev/jsonwire-grid/pool/capabilities"
 	"github.com/stretchr/testify/assert"
@@ -294,3 +295,37 @@ func testStorage_SetBusy(t *testing.T, p PrepareInterface) {
 	assert.Equal(t, pool.NodeStatusBusy, node.Status, "Node not Busy")
 	assert.Equal(t, expectedSessionID, node.SessionID, "Not saved sessionID")
 }
+
+// testStorage_UpdateAdderss_UpdatesValue успешное обновления адреса ноды
+func testStorage_UpdateAdderss_UpdatesValue(t *testing.T, p PrepareInterface) {
+	t.Parallel()
+	storage, deferFunc := p.CreateStorage()
+	defer deferFunc()
+	node := pool.Node{SessionID: "sess", Key: "123", Status: pool.NodeStatusAvailable, Address: "qqqqqq", CapabilitiesList: []capabilities.Capabilities{{"1": "2"}}}
+	err := storage.Add(node, 0)
+	if err != nil {
+		t.Fatal("Error add node, " + err.Error())
+	}
+	expectedAddress := "newAddressId"
+	err = storage.UpdateAddress(node, expectedAddress)
+	assert.Nil(t, err)
+	node, err = storage.GetBySession("sess")
+	if err != nil {
+		t.Fatal("Error add node, " + err.Error())
+	}
+	assert.Equal(t, expectedAddress, node.Address, "Not updated address")
+}
+
+// testStorage_UpdateAdderss_ReturnsErrNotFound попытка обновить несуществующую ноду
+func testStorage_UpdateAdderss_ReturnsErrNotFound(t *testing.T, p PrepareInterface) {
+	t.Parallel()
+	storage, deferFunc := p.CreateStorage()
+	defer deferFunc()
+	node := pool.Node{SessionID: "sess", Key: "123", Status: pool.NodeStatusAvailable, Address: "qqqqqq", CapabilitiesList: []capabilities.Capabilities{{"1": "2"}}}
+	err := storage.Add(pool.Node{Key:"12345"}, 0)
+	if err != nil {
+		t.Fatal("Error add node, " + err.Error())
+	}
+	err = storage.UpdateAddress(node, "trololo")
+	assert.Equal(t, storageLib.ErrNotFound, err)
+}

storage/tests/mysql_test.go

@@ -155,3 +155,13 @@ func TestMysqlStorage_SetAvailable(t *testing.T) {
 func TestMysqlStorage_SetBusy(t *testing.T) {
 	testStorage_SetBusy(t, mv)
 }
+
+// TestMysqlStorage_UpdateAdderss_UpdatesValue see testStorage_UpdateAdderss_UpdatesValue
+func TestMysqlStorage_UpdateAdderss_UpdatesValue(t *testing.T) {
+	testStorage_UpdateAdderss_UpdatesValue(t, mv)
+}
+
+// TestMysqlStorage_UpdateAdderss_ReturnsErrNotFound see testStorage_UpdateAdderss_ReturnsErrNotFound
+func TestMysqlStorage_UpdateAdderss_ReturnsErrNotFound(t *testing.T) {
+	testStorage_UpdateAdderss_ReturnsErrNotFound(t, mv)
+}