QA-7710: fix

Author: Mikhail Podtserkovskiy

pool/strategy/kubernetes/provider.go

@@ -98,12 +98,8 @@ LoopWaitSelenium:
 //Destroy - destroy all pod data (idempotent operation)
 func (p *kubDnsProvider) Destroy(podName string) error {
 	err := p.clientset.CoreV1Client.Pods(p.namespace).Delete(podName, &apiV1.DeleteOptions{})
-	switch {
-	case err != nil && strings.Contains(err.Error(), "not found"):
-		// pod already deleted
-	case err != nil:
-		err = errors.New("send command pod/delete to k8s, " + err.Error())
-		return err
+	if err != nil && !strings.Contains(err.Error(), "not found") {
+		return errors.New("send command pod/delete to k8s, " + err.Error())
 	}
 	return nil
 }

pool/strategy/kubernetes/strategy.go

@@ -17,6 +17,8 @@ type Strategy struct {
 	capsComparator capabilities.ComparatorInterface
 }
 
+const cleanupFailedPodsTimeout = time.Minute * 2
+
 func (s *Strategy) Reserve(desiredCaps capabilities.Capabilities) (pool.Node, error) {
 	nodeConfig := s.findApplicableConfig(s.config.NodeList, desiredCaps)
 	if nodeConfig == nil {
@@ -32,7 +34,7 @@ func (s *Strategy) Reserve(desiredCaps capabilities.Capabilities) (pool.Node, er
 	nodeAddress, err := s.provider.Create(podName, nodeConfig.Params)
 	if err != nil {
 		go func(podName string) {
-			time.Sleep(time.Minute * 2)
+			time.Sleep(cleanupFailedPodsTimeout)
 			_ = s.provider.Destroy(podName) // на случай если что то криво создалось
 		}(podName)
 		return pool.Node{}, errors.New("create node by provider, " + err.Error())