Skip to content

Commit 6c8983b

Browse files
committed
fix: dropdown inside scrollable body modal be clipped
issue reproduce: ```python with popup('bug'): put_select("name", list(range(10))) ```
1 parent 993b61f commit 6c8983b

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

webiojs/src/handlers/popup.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class PopupHandler implements CommandHandler {
6060
static get_element(spec: { title: string, content: any[], closable: boolean, implicit_close: boolean, size: string }) {
6161
// https://v4.bootcss.com/docs/components/modal/#options
6262
const tpl = `<div class="modal fade" {{^implicit_close}}data-backdrop="static"{{/implicit_close}} aria-labelledby="model-id-{{ dom_id }}" tabindex="-1" role="dialog" aria-hidden="true">
63-
<div class="modal-dialog modal-dialog-scrollable {{#large}}modal-lg{{/large}} {{#small}}modal-sm{{/small}}" role="document">
63+
<div class="modal-dialog {{#large}}modal-lg{{/large}} {{#small}}modal-sm{{/small}}" role="document">
6464
<div class="modal-content">
6565
<div class="modal-header">
6666
<h5 class="modal-title" id="model-id-{{ mid }}">{{ title }}</h5>
@@ -75,12 +75,6 @@ export class PopupHandler implements CommandHandler {
7575
{{& pywebio_output_parse}}
7676
{{/content}}
7777
</div>
78-
<!--
79-
<div class="modal-footer">
80-
<button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
81-
<button type="button" class="btn btn-primary">Submit</button>
82-
</div>
83-
-->
8478
</div>
8579
</div>
8680
</div>`;

0 commit comments

Comments
 (0)