Fixed fork tests

Author: mikicz

test_naucse/test_forks.py

@@ -169,6 +169,13 @@ def model(fork):
 def client(model, mocker):
     """ This fixture generates a client for testing endpoints, model will be used.
     """
+    # these methods have the @reify decorator, however we need for them to be recalculated
+    # so ``naucse.utils.routes.forks_enabled`` can be tested
+    if hasattr(model, "safe_runs"):
+        delattr(model, "safe_runs")
+    if hasattr(model, "safe_run_years"):
+        delattr(model, "safe_run_years")
+
     mocker.patch("naucse.routes._cached_model", model)
     from naucse import app
     app.testing = True
@@ -299,7 +306,10 @@ def test_courses_page(mocker, client: FlaskClient):
     # but working forks are still present
     assert b"Course title" in response.data
 
-    # test ignoring forks
+
+def test_courses_page_ignore_forks(mocker, client: FlaskClient):
+    """ Tests ignoring forks in courses page
+    """
     mocker.patch("naucse.utils.routes.forks_enabled", lambda: False)
     mocker.patch("naucse.utils.routes.raise_errors_from_forks", lambda: True)
 
@@ -311,11 +321,12 @@ def test_courses_page(mocker, client: FlaskClient):
 def test_runs_page(mocker, client: FlaskClient):
     """ Tests how the /runs/ page behaves when a fork isn't returning information about a course.
     """
+    mocker.patch("naucse.utils.routes.forks_enabled", lambda: True)
     mocker.patch("naucse.utils.routes.raise_errors_from_forks", lambda: True)
 
     # there's a problem in one of the branches, it should raise error if the conditions for raising are True
     with pytest.raises(BuildError):
-        client.get("/runs/")
+        client.get("/runs/all/")
 
     # unless problems are silenced
     mocker.patch("naucse.utils.routes.raise_errors_from_forks", lambda: False)
@@ -325,11 +336,14 @@ def test_runs_page(mocker, client: FlaskClient):
     # but working forks are still present
     assert b"Run title" in response.data
 
-    # test ignoring forks
+
+def test_runs_page_ignore_forks(mocker, client: FlaskClient):
+    """ Tests ignoring forks in runs page
+    """
     mocker.patch("naucse.utils.routes.forks_enabled", lambda: False)
     mocker.patch("naucse.utils.routes.raise_errors_from_forks", lambda: True)
 
-    response = client.get("/runs/")
+    response = client.get("/runs/all/")
 
     assert b"Broken run title" not in response.data
     assert b"Run title" not in response.data