Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Commit c165f40

Browse files
Yuhtawenleix
authored andcommitted
Fix arrow schema conversion for complex types (#399)
Summary: Pull Request resolved: #399 X-link: facebookincubator/velox#1857 1. Use `List` instead of `LargeList` because `vector_size_t` is 32 bits large. 2. Fix the conversion of `Map`; arrow requires an extra layer of struct type between the map type and key-value types. Reviewed By: pedroerp Differential Revision: D37356848 fbshipit-source-id: 6289708cdd207c27c2bb30fe4c4827a65acd7e6d
1 parent 22ed674 commit c165f40

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

csrc/velox/column.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "velox/vector/BaseVector.h"
2323
#include "velox/vector/ComplexVector.h"
2424
#include "velox/vector/FlatVector.h"
25+
#include "velox/vector/arrow/Abi.h"
2526
#include "velox/vector/arrow/Bridge.h"
2627

2728
// TODO: Move uses of static variables into .cpp. Static variables are local to

csrc/velox/lib.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include "velox/functions/prestosql/registration/RegistrationFunctions.h"
2626
#include "velox/type/Type.h"
2727
#include "velox/vector/TypeAliases.h"
28+
#include "velox/vector/arrow/Abi.h"
2829
#include "velox/vector/arrow/Bridge.h"
2930

3031
#ifdef USE_TORCH

0 commit comments

Comments
 (0)