Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Commit 458dc0b

Browse files
laithsakkafacebook-github-bot
authored andcommitted
Pass not nullable context and results by reference (#479)
Summary: Pull Request resolved: #479 X-link: facebookincubator/velox#2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Reviewed By: kagamiori Differential Revision: D38946493 fbshipit-source-id: ce4e2714332cb13e9b0c6a9a35e93fcd96ae038a
1 parent a81d5c2 commit 458dc0b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

csrc/velox/column.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ std::unique_ptr<BaseColumn> OperatorHandle::call(
452452
&TorchArrowGlobalStatic::execContext(), exprSet_.get(), inputRows.get());
453453
velox::SelectivityVector select(size);
454454
std::vector<velox::VectorPtr> outputRows(1);
455-
exprSet_->eval(0, 1, true, select, &evalCtx, &outputRows);
455+
exprSet_->eval(0, 1, true, select, evalCtx, outputRows);
456456

457457
// TODO: This causes an extra type-based dispatch.
458458
// We can optimize it by template OperatorHandle by return type

0 commit comments

Comments
 (0)