Skip to content

Commit efdd8de

Browse files
luciangfacebook-github-bot
authored andcommitted
fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-linkage (#137)
Summary: X-link: facebook/CacheLib#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: df3fa684c8655184dd8f87045542cd7f5704a65e
1 parent 4ed682c commit efdd8de

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

gloo/broadcast_one_to_all.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ class BroadcastOneToAll : public Algorithm {
118118
const int rootPointerRank_;
119119

120120
// For the sender (root)
121-
using forSender = struct {
121+
struct forSender {
122122
int dummy;
123123
std::unique_ptr<transport::Buffer> clearToSendBuffer;
124124
std::unique_ptr<transport::Buffer> sendBuffer;
@@ -127,7 +127,7 @@ class BroadcastOneToAll : public Algorithm {
127127
std::vector<std::unique_ptr<forSender>> sender_;
128128

129129
// For all receivers
130-
using forReceiver = struct {
130+
struct forReceiver {
131131
int dummy;
132132
std::unique_ptr<transport::Buffer> clearToSendBuffer;
133133
std::unique_ptr<transport::Buffer> recvBuffer;

gloo/cuda_broadcast_one_to_all.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class CudaBroadcastOneToAll : public Algorithm {
5252
const bool synchronizeDeviceOutputs_;
5353

5454
// For the sender (root)
55-
using forSender = struct {
55+
struct forSender {
5656
int dummy;
5757
std::unique_ptr<transport::Buffer> clearToSendBuffer;
5858
std::unique_ptr<transport::Buffer> sendBuffer;
@@ -61,7 +61,7 @@ class CudaBroadcastOneToAll : public Algorithm {
6161
std::vector<std::unique_ptr<forSender>> sender_;
6262

6363
// For all receivers
64-
using forReceiver = struct {
64+
struct forReceiver {
6565
int dummy;
6666
std::unique_ptr<transport::Buffer> clearToSendBuffer;
6767
std::unique_ptr<transport::Buffer> recvBuffer;

0 commit comments

Comments
 (0)