Skip to content

Commit c58d3fa

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Fix shadowed variable in gloo/allgather.h
Summary: Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so. This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug. **What's a shadowed variable?** Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs. This diff fixes such an issue by renaming the variable. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: dmm-fb Differential Revision: D52959003 fbshipit-source-id: 3911d93bed3547220a2335473ccee1130ba4484e
1 parent bfd1067 commit c58d3fa

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

gloo/allgather.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ class AllgatherOptions {
4242
out = context->createUnboundBuffer(ptr, elements * sizeof(T));
4343
}
4444

45-
void setTag(uint32_t tag) {
46-
this->tag = tag;
45+
void setTag(uint32_t tag_2) {
46+
this->tag = tag_2;
4747
}
4848

49-
void setTimeout(std::chrono::milliseconds timeout) {
50-
this->timeout = timeout;
49+
void setTimeout(std::chrono::milliseconds timeout_2) {
50+
this->timeout = timeout_2;
5151
}
5252

5353
protected:

0 commit comments

Comments
 (0)