Skip to content

Commit aff690e

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove unused variables in gloo/test/transport_test.cc
Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: bunnypak, dmm-fb Differential Revision: D53011655 fbshipit-source-id: fc7d556051fa9373d4e70d901b7ed5481ca3b29a
1 parent 43b1115 commit aff690e

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

gloo/test/transport_test.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ TEST_P(TransportMultiProcTest, IoTimeouts) {
166166
TEST_P(TransportMultiProcTest, UnboundIoErrors) {
167167
const auto processCount = std::get<0>(GetParam());
168168
const auto sleepMs = std::get<2>(GetParam());
169-
const auto mode = std::get<3>(GetParam());
170169
const auto transport = std::get<4>(GetParam());
171170

172171
spawnAsync(transport, processCount, [&](std::shared_ptr<Context> context) {
@@ -214,7 +213,6 @@ TEST_P(TransportMultiProcTest, UnboundIoErrors) {
214213
TEST_P(TransportMultiProcTest, UnboundIoTimeout) {
215214
const auto processCount = std::get<0>(GetParam());
216215
const auto sleepMs = std::get<2>(GetParam());
217-
const auto mode = std::get<3>(GetParam());
218216
const auto transport = std::get<4>(GetParam());
219217

220218
spawnAsync(transport, processCount, [&](std::shared_ptr<Context> context) {
@@ -266,7 +264,6 @@ TEST_P(TransportMultiProcTest, UnboundIoTimeout) {
266264
TEST_P(TransportMultiProcTest, UnboundIoTimeoutOverride) {
267265
const auto processCount = std::get<0>(GetParam());
268266
const auto sleepMs = std::get<2>(GetParam());
269-
const auto mode = std::get<3>(GetParam());
270267
const auto transport = std::get<4>(GetParam());
271268

272269
// Use lower timeout than default and pass directly to waitSend/waitRecv.

0 commit comments

Comments
 (0)