Skip to content

Commit 9facc40

Browse files
Add third-party spdlog (v1.15.3) as a submodule
Also modifies Github CI config to ensure the checkout action also checks out the submodule.
1 parent a735743 commit 9facc40

File tree

6 files changed

+26
-0
lines changed

6 files changed

+26
-0
lines changed

.github/workflows/build-linux.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ jobs:
2323
steps:
2424
- name: Checkout code
2525
uses: actions/checkout@v4
26+
with:
27+
submodules: true
2628
- name: Setup environment
2729
run: |
2830
sudo apt-get install -y libssl-dev

.github/workflows/build-windows.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
uses: microsoft/setup-msbuild@v2
2525
- name: Checkout code
2626
uses: actions/checkout@v4
27+
with:
28+
submodules: true
2729
- name: Set up Python 3.10
2830
uses: actions/setup-python@v5
2931
with:

.github/workflows/super-linter.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ jobs:
2424
# Full git history is needed to get a proper list of changed files
2525
# within `super-linter`
2626
fetch-depth: 0
27+
submodules: true
2728
- name: Super-linter
2829
uses: super-linter/super-linter@v7.3.0 # x-release-please-version
2930
env:

.gitmodules

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[submodule "third_party/spdlog"]
2+
path = third_party/spdlog
3+
url = https://github.com/gabime/spdlog.git

README.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,23 @@ Optional dependencies are:
6262

6363
Please refer to [docs/](docs/) for detailed documentation.
6464

65+
## Cloning
66+
67+
Gloo makes use of [Git submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules)
68+
for third-party build-time dependencies. When cloning, ensure that you
69+
initialize and sync submodules:
70+
71+
``` shell
72+
git clone --recurse-submodules https://github.com/pytorch/gloo.git # or use SSH remote
73+
```
74+
75+
Or, if you already cloned without submodules, run the following in the existing
76+
local repository:
77+
78+
``` shell
79+
git submodule update --init --recursive
80+
```
81+
6582
## Building
6683

6784
You can build Gloo using CMake.

third_party/spdlog

Submodule spdlog added at 6fa3601

0 commit comments

Comments
 (0)