Skip to content

Commit 9e866dc

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove unused variables in gloo/test/reduce_scatter_test.cc
Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: bunnypak, dmm-fb Differential Revision: D53011663 fbshipit-source-id: e7bdca967333e551ca2d38f4b60381eae8681f09
1 parent aff690e commit 9e866dc

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

gloo/test/reduce_scatter_test.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ TEST_P(ReduceScatterTest, SinglePointer) {
8181
const auto contextSize = std::get<1>(GetParam());
8282
const auto dataSize = std::get<2>(GetParam());
8383
const auto fn = std::get<3>(GetParam());
84-
const auto base = std::get<4>(GetParam());
8584

8685
spawn(transport, contextSize, [&](std::shared_ptr<Context> context) {
8786
const auto contextRank = context->rank;

0 commit comments

Comments
 (0)