Skip to content

Commit 1b4337a

Browse files
authored
[ROCm] Support GLOO on Windows (#461)
1 parent 54cbae0 commit 1b4337a

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

cmake/Dependencies.cmake

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,15 +140,17 @@ if(USE_ROCM)
140140
include(cmake/Hip.cmake)
141141
if(HAVE_HIP)
142142
include(cmake/Hipify.cmake)
143-
list(APPEND HIP_CXX_FLAGS -fPIC)
144143
list(APPEND HIP_CXX_FLAGS -D__HIP_PLATFORM_HCC__=1)
145144
list(APPEND HIP_CXX_FLAGS -DCUDA_HAS_FP16=1)
146145
list(APPEND HIP_CXX_FLAGS -D__HIP_NO_HALF_OPERATORS__=1)
147146
list(APPEND HIP_CXX_FLAGS -D__HIP_NO_HALF_CONVERSIONS__=1)
148147
list(APPEND HIP_CXX_FLAGS -DHIP_VERSION=${HIP_VERSION_MAJOR})
149-
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-negative)
150-
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-overflow)
151-
list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier)
148+
if(NOT WIN32)
149+
list(APPEND HIP_CXX_FLAGS -fPIC)
150+
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-negative)
151+
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-overflow)
152+
list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier)
153+
endif()
152154
list(APPEND HIP_CXX_FLAGS -DUSE_MIOPEN)
153155

154156
set(HIP_CLANG_FLAGS ${HIP_CXX_FLAGS})

cmake/Hipify.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ endfunction(prepend)
99
set(HIPIFY_SCRIPTS_DIR ${PROJECT_SOURCE_DIR}/tools/amd_build)
1010
file(GLOB HIPIFY_SCRIPTS ${HIPIFY_SCRIPTS_DIR}/*.py)
1111
set(HIPIFY_OUTPUT_ROOT_DIR ${PROJECT_BINARY_DIR}/hip)
12+
13+
find_package (Python3 COMPONENTS Interpreter)
1214
set(HIPIFY_COMMAND
13-
${HIPIFY_SCRIPTS_DIR}/build_amd.py
15+
${Python3_EXECUTABLE} ${HIPIFY_SCRIPTS_DIR}/build_amd.py
1416
--project-directory ${PROJECT_SOURCE_DIR}
1517
--output-directory ${HIPIFY_OUTPUT_ROOT_DIR}
1618
)

0 commit comments

Comments
 (0)