Skip to content

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Oct 10, 2025

Stack from ghstack (oldest at bottom):

Summary: As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

Test Plan: CI

**Summary:** As a follow-up to #2994,
this commit removes all quantization functions that were used
as configs. These functions were deprecated in 0.14.0 and will
be removed in the next release, 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3146

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41d0bfb with merge base 6259e98 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2025
@andrewor14 andrewor14 added the topic: bc-breaking Use this tag if this PR breaks backward compatibility label Oct 10, 2025
andrewor14 added a commit that referenced this pull request Oct 13, 2025
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

ghstack-source-id: 7c81628
Pull Request resolved: #3146
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
@andrewor14 andrewor14 changed the base branch from gh/andrewor14/28/base to main October 13, 2025 17:44
andrewor14 added a commit that referenced this pull request Oct 13, 2025
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

ghstack-source-id: 7d1f063
Pull Request resolved: #3146
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
@meta-codesync
Copy link

meta-codesync bot commented Nov 7, 2025

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this in D86528619.

**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
andrewor14 added a commit to andrewor14/torchtune that referenced this pull request Nov 7, 2025
andrewor14 added a commit to andrewor14/torchtune that referenced this pull request Nov 7, 2025
@andrewor14
Copy link
Contributor Author

andrewor14 commented Nov 7, 2025

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

THIS IS WRONG, the real diff is https://www.internalfb.com/diff/D86528619

@andrewor14 andrewor14 merged commit e8c4d09 into main Nov 10, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bc-breaking Use this tag if this PR breaks backward compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants