Skip to content

Commit 9a970cf

Browse files
correct grammatical error in CONTRIBUTING.md to "in their own right" (#14883)
The pronoun and its noun did not agree in grammatical number. Furthermore, the previous author seems to have started writing the idiomatic phrase "in its own right", and then gotten confused and completed it by writing the end of the idiomatic phrase "on its own merits". The former better expresses the concept under discussion here (which could also be paraphrased as "themselves", "in-and-of-themselves", or "also", although less precisely), so I've gone with it.
1 parent d6f4a0f commit 9a970cf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def foo(x: Incomplete | None) -> list[Incomplete]: ...
311311
### What to do when a project's documentation and implementation disagree
312312

313313
Type stubs are meant to be external type annotations for a given
314-
library. While they are useful documentation in its own merit, they
314+
library. While they are useful documentation in their own right, they
315315
augment the project's concrete implementation, not the project's
316316
documentation. Whenever you find them disagreeing, model the type
317317
information after the actual implementation and file an issue on the

0 commit comments

Comments
 (0)