Added another step on contributing.md to avoid pip install issue #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
reviewed
Dec 9, 2024
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
Thanks @mgiannopoulos24! Έκανα 2 comments για κάποια improvements. Ψιλό-άσχετα με το συγκεκριμένο PR, οπότε αν θες να κάνουμε merge αυτό και δουλεύουμε στα points μου σε ένα καινούριο (αν θες, μπορώ να τα κάνω κι εγώ, ό,τι προτιμάς).
Contributor
Author
|
εντάξει θα το φτιάξω εγώ. |
lysnikolaou
approved these changes
Dec 9, 2024
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM! Thanks @mgiannopoulos24!
skpanagiotis
pushed a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ποιο issue κλείνει το συγκεκριμένο PR;
Closes #569
Περιγραφή του PR
Προστέθηκε ένα επιπλέον βήμα στο
CONTRIBUTING.mdτο οποίο θα μας συμβουλεύει να χρησιμοποιήσουμε και το παρακάτω command ώστε να κάνουμε clone και το cpython ολόκληρο.git submodule update --init