Update linters and python version for linting in CI (#15200)

x-ref: #15197

Author: hamdanal

.github/workflows/test.yml

@@ -97,7 +97,7 @@ jobs:
           # but it's useful to run them with tox too,
           # to ensure the tox env works as expected
         - name: Formatting with Black + isort and code style with flake8
-          python: '3.7'
+          python: '3.10'
           arch: x64
           os: ubuntu-latest
           toxenv: lint

.pre-commit-config.yaml

@@ -4,16 +4,16 @@ repos:
     hooks:
       - id: black
   - repo: https://github.com/pycqa/isort
-    rev: 5.11.5  # must match test-requirements.txt (cannot use version 5.12 until python 3.7 support is dropped)
+    rev: 5.12.0  # must match test-requirements.txt
     hooks:
       - id: isort
   - repo: https://github.com/pycqa/flake8
-    rev: 5.0.4  # must match test-requirements.txt (cannot use version 6 until python 3.7 support is dropped)
+    rev: 6.0.0  # must match test-requirements.txt
     hooks:
       - id: flake8
         additional_dependencies:
-          - flake8-bugbear==22.12.6  # must match test-requirements.txt
-          - flake8-noqa==1.3.0       # must match test-requirements.txt
+          - flake8-bugbear==23.3.23  # must match test-requirements.txt
+          - flake8-noqa==1.3.1       # must match test-requirements.txt
 
 ci:
   # We run flake8 as part of our GitHub Actions suite in CI

CONTRIBUTING.md

@@ -44,6 +44,10 @@ python3 -m pip install -e .
 hash -r  # This resets shell PATH cache, not necessary on Windows
 ```
 
+> **Note**
+> You'll need Python 3.8 or higher to install all requirements listed in
+> test-requirements.txt
+
 ### Running tests
 
 Running the full test suite can take a while, and usually isn't necessary when

pyproject.toml

@@ -28,6 +28,7 @@ force-exclude = '''
 '''
 
 [tool.isort]
+py_version = 37
 profile = "black"
 line_length = 99
 combine_as_imports = true

test-requirements.txt

@@ -3,10 +3,10 @@
 attrs>=18.0
 black==23.3.0  # must match version in .pre-commit-config.yaml
 filelock>=3.3.0
-flake8==5.0.4           # must match version in .pre-commit-config.yaml
-flake8-bugbear==22.12.6 # must match version in .pre-commit-config.yaml
-flake8-noqa==1.3.0      # must match version in .pre-commit-config.yaml
-isort[colors]==5.11.5   # must match version in .pre-commit-config.yaml
+flake8==6.0.0; python_version >= "3.8"           # must match version in .pre-commit-config.yaml
+flake8-bugbear==23.3.23; python_version >= "3.8" # must match version in .pre-commit-config.yaml
+flake8-noqa==1.3.1; python_version >= "3.8"      # must match version in .pre-commit-config.yaml
+isort[colors]==5.12.0; python_version >= "3.8"   # must match version in .pre-commit-config.yaml
 lxml>=4.9.1; (python_version<'3.11' or sys_platform!='win32') and python_version<'3.12'
 psutil>=4.0
 # pytest 6.2.3 does not support Python 3.10

tox.ini

@@ -40,6 +40,7 @@ commands =
 
 [testenv:lint]
 description = check the code style
+skip_install = true
 commands =
     flake8 {posargs}
     black --check --diff --color .