gh-139707: Add docs for optional modules #140171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... And add Stan as contributor: Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Member
|
|
hugovk
reviewed
Oct 15, 2025
vstinner
reviewed
Oct 16, 2025
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
encukou
requested review from
AA-Turner,
berkerpeksag,
corona10,
erlend-aasland,
ethanfurman,
gpshead,
pfmoore,
picnixz,
pradyunsg and
terryjreedy
as code owners
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
terryjreedy
reviewed
Oct 25, 2025
|
|
||
| * configuration, browsers, and other dialogs | ||
|
|
||
| .. include:: ../includes/optional-module.rst |
Member
There was a problem hiding this comment.
This is the appropriate place for this, rather than buried in the idlelib entry at the end. Possible suggestion to make the include fit even better.
Suggested change
| .. include:: ../includes/optional-module.rst | |
| The IDLE application is implemented in the idlelib package. | |
| .. include:: ../includes/optional-module.rst |
with idlelib linked to the entry at the end of the file. OR I could do in a separate PR.
I am also considering adding ":mod: idlelib and " to the beginning of the title in a separate issue. Would have to look at the result, including indexing.
Member
Author
There was a problem hiding this comment.
Thanks! I added this suggestion.
Shakacro
approved these changes
Nov 1, 2025
Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
StanFromIreland
approved these changes
Nov 5, 2025
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Two little nits, otherwise LGTM.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @encukou, I could not cleanly backport this to |
|
GH-141204 is a backport of this pull request to the 3.14 branch. |
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Nov 7, 2025
(cherry picked from commit d2ce6d7) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Author: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Victor Stinner <vstinner@python.org>
encukou
added a commit
that referenced
this pull request
Nov 10, 2025
(cherry picked from commit d2ce6d7) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev> Co-authored-by: Author: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--140171.org.readthedocs.build/