Stop using base64 for escaping bash

Signed-off-by: Aleksei Stepanov <penguinolog@gmail.com>

Author: penguinolog

exec_helpers/_ssh_client_base.py

@@ -19,11 +19,11 @@
 __all__ = ("SSHClientBase", "SshExecuteAsyncResult")
 
 # Standard Library
-import base64
 import concurrent.futures
 import copy
 import datetime
 import logging
+import shlex
 import stat
 import time
 import typing
@@ -479,8 +479,7 @@ def _execute_async(  # pylint: disable=arguments-differ
 
         started = datetime.datetime.utcnow()
         if self.sudo_mode:
-            encoded_cmd = base64.b64encode(cmd.encode("utf-8")).decode("utf-8")
-            cmd = f'sudo -S bash -c \'eval "$(base64 -d <(echo "{encoded_cmd}"))"\''
+            cmd = f'sudo -S bash -c "eval {shlex.quote(cmd)}"'
             chan.exec_command(cmd)  # nosec  # Sanitize on caller side
             if stdout.channel.closed is False:
                 # noinspection PyTypeChecker

test/test_ssh_client_execute_async_special.py

@@ -13,7 +13,7 @@
 #    under the License.
 
 # Standard Library
-import base64
+import shlex
 import typing
 from unittest import mock
 
@@ -55,10 +55,10 @@ def read_stream(stream: FakeFileStream) -> typing.Tuple[bytes, ...]:
 password = "pass"
 
 command = "ls ~\nline 2\nline 3\nline с кирилицей"
+cmd_execute = f"{command}\n"
 command_log = f"Executing command:\n{command.rstrip()!r}\n"
 stdout_src = (b" \n", b"2\n", b"3\n", b" \n")
 stderr_src = (b" \n", b"0\n", b"1\n", b" \n")
-encoded_cmd = base64.b64encode(f"{command}\n".encode("utf-8")).decode("utf-8")
 
 print_stdin = 'read line; echo "$line"'
 default_timeout = 60 * 60  # 1 hour
@@ -120,7 +120,7 @@ def test_001_execute_async_sudo(ssh, ssh_transport_channel):
     ssh_transport_channel.assert_has_calls(
         (
             mock.call.makefile_stderr("rb"),
-            mock.call.exec_command(f'sudo -S bash -c \'eval "$(base64 -d <(echo "{encoded_cmd}"))"\''),
+            mock.call.exec_command(f'sudo -S bash -c \"eval {shlex.quote(cmd_execute)}\"'),
         )
     )