Update MyPy

Now logging is correctly inspected and should not be scipped in
typecheck.

Author: penguinolog

.travis.yml

@@ -74,7 +74,7 @@ jobs:
     install:
     - *upgrade_python_toolset
     - *install_deps
-    - pip install --upgrade "mypy >= 0.670"
+    - pip install --upgrade "mypy >= 0.700"
     script:
     - mypy --strict exec_helpers
   - <<: *static_analysis

azure-pipelines.yml

@@ -70,7 +70,7 @@ jobs:
       python -m pip install --upgrade pip
       pip install -U setuptools
       pip install -r requirements.txt
-      pip install -U mypy
+      pip install -U "mypy>=0.700"
     displayName: 'Install dependencies'
 
   - script: |

exec_helpers/_ssh_client_base.py

@@ -592,7 +592,7 @@ def execute_async(  # pylint: disable=arguments-differ
         """
         cmd_for_log: str = self._mask_command(cmd=command, log_mask_re=log_mask_re)
 
-        self.logger.log(  # type: ignore
+        self.logger.log(
             level=logging.INFO if verbose else logging.DEBUG, msg=_log_templates.CMD_EXEC.format(cmd=cmd_for_log)
         )
 
@@ -770,7 +770,7 @@ def execute_through_host(
         .. versionchanged:: 4.0.0 Expose stdin and log_mask_re as optional keyword-only arguments
         """
         cmd_for_log: str = self._mask_command(cmd=command, log_mask_re=log_mask_re)
-        self.logger.log(  # type: ignore
+        self.logger.log(
             level=logging.INFO if verbose else logging.DEBUG, msg=_log_templates.CMD_EXEC.format(cmd=cmd_for_log)
         )
 

exec_helpers/api.py

@@ -350,7 +350,7 @@ def execute(
             **kwargs,
         )
         message = f"Command {result.cmd!r} exit code: {result.exit_code!s}"
-        self.logger.log(level=logging.INFO if verbose else logging.DEBUG, msg=message)  # type: ignore
+        self.logger.log(level=logging.INFO if verbose else logging.DEBUG, msg=message)
         return result
 
     def __call__(

exec_helpers/async_api/api.py

@@ -226,7 +226,7 @@ async def execute(  # type: ignore
             **kwargs,
         )
         message: str = f"Command {result.cmd!r} exit code: {result.exit_code!s}"
-        self.logger.log(level=logging.INFO if verbose else logging.DEBUG, msg=message)  # type: ignore
+        self.logger.log(level=logging.INFO if verbose else logging.DEBUG, msg=message)
         return result
 
     async def __call__(  # type: ignore

exec_helpers/async_api/exec_result.py

@@ -43,7 +43,7 @@ async def _poll_stream(  # type: ignore
             async for line in src:
                 dst.append(line)
                 if log:
-                    log.log(  # type: ignore
+                    log.log(
                         level=logging.INFO if verbose else logging.DEBUG,
                         msg=line.decode("utf-8", errors="backslashreplace").rstrip(),
                     )

exec_helpers/async_api/subprocess_runner.py

@@ -216,7 +216,7 @@ async def execute_async(  # type: ignore
         """
         cmd_for_log: str = self._mask_command(cmd=command, log_mask_re=log_mask_re)
 
-        self.logger.log(  # type: ignore
+        self.logger.log(
             level=logging.INFO if verbose else logging.DEBUG, msg=_log_templates.CMD_EXEC.format(cmd=cmd_for_log)
         )
 

exec_helpers/exec_result.py

@@ -282,7 +282,7 @@ def _poll_stream(
             for line in src:
                 dst.append(line)
                 if log:
-                    log.log(  # type: ignore
+                    log.log(
                         level=logging.INFO if verbose else logging.DEBUG,
                         msg=line.decode("utf-8", errors="backslashreplace").rstrip(),
                     )

exec_helpers/subprocess_runner.py

@@ -243,7 +243,7 @@ def execute_async(  # pylint: disable=arguments-differ
         """
         cmd_for_log: str = self._mask_command(cmd=command, log_mask_re=log_mask_re)
 
-        self.logger.log(  # type: ignore
+        self.logger.log(
             level=logging.INFO if verbose else logging.DEBUG, msg=_log_templates.CMD_EXEC.format(cmd=cmd_for_log)
         )
 

tox.ini

@@ -99,7 +99,7 @@ commands = pipdeptree
 
 [testenv:mypy]
 deps =
-    mypy>=0.670
+    mypy>=0.700
     lxml
     -r{toxinidir}/CI_REQUIREMENTS.txt
 commands = mypy --strict --xslt-html-report mypy_report -p exec_helpers