3.4 (#70)

* Support python 3.4 (and later remove from ver. 1.x)
* clean-up type comments vs type hints

Author: penguinolog

.travis.yml

@@ -2,6 +2,7 @@ sudo: false
 language: python
 os: linux
 python:
+- 3.4
 - 3.5
 - 3.6
 - &mainstream_python 3.7-dev

README.rst

@@ -42,12 +42,13 @@ Pros:
 
 ::
 
+    Python 3.4
     Python 3.5
     Python 3.6
     Python 3.7
     PyPy3 3.5+
 
-.. note:: For Python 2.7, 3.4 and PyPy please use versions 1.x.x
+.. note:: For Python 2.7 and PyPy please use versions 1.x.x
 
 This package includes:
 

exec_helpers/_ssh_client_base.py

@@ -572,7 +572,7 @@ def execute_async(
         :param command: Command for execution
         :type command: str
         :param stdin: pass STDIN text to the process
-        :type stdin: typing.Union[typing.AnyStr, bytearray, None]
+        :type stdin: typing.Union[str, bytes, bytearray, None]
         :param open_stdout: open STDOUT stream for read
         :type open_stdout: bool
         :param open_stderr: open STDERR stream for read

exec_helpers/api.py

@@ -141,7 +141,7 @@ def execute_async(
         :param command: Command for execution
         :type command: str
         :param stdin: pass STDIN text to the process
-        :type stdin: typing.Union[typing.AnyStr, bytearray, None]
+        :type stdin: typing.Union[str, bytes, bytearray, None]
         :param open_stdout: open STDOUT stream for read
         :type open_stdout: bool
         :param open_stderr: open STDERR stream for read

exec_helpers/exec_result.py

@@ -44,7 +44,7 @@ class ExecResult:
 
     def __init__(
         self,
-        cmd,  # type: str
+        cmd: str,
         stdin: typing.Union[bytes, str, bytearray, None] = None,
         stdout: typing.Optional[typing.Iterable[bytes]] = None,
         stderr: typing.Optional[typing.Iterable[bytes]] = None,
@@ -55,7 +55,7 @@ def __init__(
         :param cmd: command
         :type cmd: str
         :param stdin: string STDIN
-        :type stdin: typing.Union[typing.AnyStr, bytearray, None]
+        :type stdin: typing.Union[str, bytes, bytearray, None]
         :param stdout: binary STDOUT
         :type stdout: typing.Optional[typing.Iterable[bytes]]
         :param stderr: binary STDERR
@@ -145,7 +145,7 @@ def _get_brief(cls, data: typing.Tuple[bytes, ...]) -> str:
         )
 
     @property
-    def cmd(self):  # type: () -> str
+    def cmd(self) -> str:
         """Executed command.
 
         :rtype: str

exec_helpers/subprocess_runner.py

@@ -204,10 +204,10 @@ def execute_async(
         pass  # pragma: no cover
 
     # pylint: enable=unused-argument
-    def execute_async(  # type: ignore  # noqa: F811
+    def execute_async(  # noqa: F811
         self,
         command: str,
-        stdin: typing.Union[typing.AnyStr, bytearray, None] = None,
+        stdin: typing.Union[str, bytes, bytearray, None] = None,
         open_stdout: bool = True,
         open_stderr: bool = True,
         verbose: bool = False,
@@ -219,7 +219,7 @@ def execute_async(  # type: ignore  # noqa: F811
         :param command: Command for execution
         :type command: str
         :param stdin: pass STDIN text to the process
-        :type stdin: typing.Union[typing.AnyStr, bytearray, None]
+        :type stdin: typing.Union[str, bytes, bytearray, None]
         :param open_stdout: open STDOUT stream for read
         :type open_stdout: bool
         :param open_stderr: open STDERR stream for read
@@ -258,9 +258,9 @@ def execute_async(  # type: ignore  # noqa: F811
 
         if stdin is not None:
             if isinstance(stdin, str):
-                stdin = stdin.encode(encoding='utf-8')  # type: ignore
+                stdin = stdin.encode(encoding='utf-8')
             elif isinstance(stdin, bytearray):
-                stdin = bytes(stdin)  # type: ignore
+                stdin = bytes(stdin)
             try:
                 process.stdin.write(stdin)
             except OSError as exc:

setup.py

@@ -228,6 +228,7 @@ def get_simple_vars_from_src(src):
     'License :: OSI Approved :: Apache Software License',
 
     'Programming Language :: Python :: 3',
+    'Programming Language :: Python :: 3.4',
     'Programming Language :: Python :: 3.5',
     'Programming Language :: Python :: 3.6',
     'Programming Language :: Python :: 3.7',
@@ -257,7 +258,7 @@ def get_simple_vars_from_src(src):
     long_description=long_description,
     classifiers=classifiers,
     keywords=keywords,
-    python_requires='>=3.5',
+    python_requires='>=3.4',
     # While setuptools cannot deal with pre-installed incompatible versions,
     # setting a lower bound is not harmful - it makes error messages cleaner. DO
     # NOT set an upper bound on setuptools, as that will lead to uninstallable

tools/build-wheels.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-PYTHON_VERSIONS="cp35-cp35m cp36-cp36m cp37-cp37m"
+PYTHON_VERSIONS="cp34-cp34m cp35-cp35m cp36-cp36m cp37-cp37m"
 
 # Avoid creation of __pycache__/*.py[c|o]
 export PYTHONDONTWRITEBYTECODE=1

tox.ini

@@ -5,7 +5,7 @@
 
 [tox]
 minversion = 2.0
-envlist = pep8, pylint, mypy, bandit, pep257, py{35,36,37,py3}, docs, py{35,36,37}-nocov
+envlist = pep8, pylint, mypy, bandit, pep257, py{34,35,36,37,py3}, docs, py{34,35,36,37}-nocov
 skipsdist = True
 skip_missing_interpreters = True
 
@@ -20,14 +20,21 @@ deps =
     pytest-cov
     pytest-html
     pytest-sugar
-    py{35,36}-nocov: Cython
+    py{34,35,36}-nocov: Cython
     -r{toxinidir}/CI_REQUIREMENTS.txt
 
 commands =
     pip freeze
     py.test --junitxml=unit_result.xml --cov-report html --self-contained-html --html=report.html --cov-config .coveragerc --cov=exec_helpers {posargs:test}
     coverage report --fail-under 97
 
+[testenv:py34-nocov]
+usedevelop = False
+commands =
+    python setup.py bdist_wheel
+    pip install exec_helpers --no-index -f dist
+    py.test -vvv {posargs:test}
+
 [testenv:py35-nocov]
 usedevelop = False
 commands =
@@ -53,6 +60,7 @@ commands =
 commands = {posargs:}
 
 [tox:travis]
+3.4 = py34,
 3.5 = py35,
 3.6 = py36,
 3.7 = py37,