Skip to content

Commit 0386b74

Browse files
authored
Move critical requirements to setup.py (#13)
* Move critical requirements to setup.py Prehistoric setuptools ignores several setup.cfg flags * Move URLs to setup.cfg This attributes are parsed by modern setuptools only, so reduce warnings
1 parent 15089b5 commit 0386b74

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

setup.cfg

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,13 @@
1+
[metadata]
2+
name = Advanced-Descriptors
3+
project_urls =
4+
Bug Tracker = https://github.com/python-useful-helpers/advanced-descriptors/issues
5+
Documentation = https://advanced-descriptors.readthedocs.io/
6+
17
[options]
28
zip_safe = False
39
packages = find:
410

5-
# While setuptools cannot deal with pre-installed incompatible versions,
6-
# setting a lower bound is not harmful - it makes error messages cleaner. DO
7-
# NOT set an upper bound on setuptools, as that will lead to uninstallable
8-
# situations as progressive releases of projects are done.
9-
# Blacklist setuptools 34.0.0-34.3.2 due to https://github.com/pypa/setuptools/issues/951
10-
# Blacklist setuptools 36.2.0 due to https://github.com/pypa/setuptools/issues/1086
11-
setup_requires =
12-
setuptools >= 21.0.0,!=24.0.0,!=34.0.0,!=34.0.1,!=34.0.2,!=34.0.3,!=34.1.0,!=34.1.1,!=34.2.0,!=34.3.0,!=34.3.1,!=34.3.2,!=36.2.0
13-
14-
python_requires = >=2.7.5,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*
15-
1611
[bdist_wheel]
1712
# This flag says that the code is written to work on both Python 2 and Python
1813
# 3. If at all possible, it is good practice to do this. If you cannot, you

setup.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,16 +240,22 @@ def get_simple_vars_from_src(src):
240240
for name, email in variables['__maintainers__'].items()
241241
),
242242
url=variables['__url__'],
243-
project_urls={
244-
"Bug Tracker": "https://github.com/python-useful-helpers/advanced-descriptors/issues",
245-
"Documentation": "https://advanced-descriptors.readthedocs.io/",
246-
},
247243
version=variables['__version__'],
248244
license=variables['__license__'],
249245
description=variables['__description__'],
250246
long_description=long_description,
251247
classifiers=classifiers,
252248
keywords=keywords,
249+
python_requires='>=2.7.5,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*',
250+
# While setuptools cannot deal with pre-installed incompatible versions,
251+
# setting a lower bound is not harmful - it makes error messages cleaner. DO
252+
# NOT set an upper bound on setuptools, as that will lead to uninstallable
253+
# situations as progressive releases of projects are done.
254+
# Blacklist setuptools 34.0.0-34.3.2 due to https://github.com/pypa/setuptools/issues/951
255+
# Blacklist setuptools 36.2.0 due to https://github.com/pypa/setuptools/issues/1086
256+
setup_requires="setuptools >= 21.0.0,!=24.0.0,"
257+
"!=34.0.0,!=34.0.1,!=34.0.2,!=34.0.3,!=34.1.0,!=34.1.1,!=34.2.0,!=34.3.0,!=34.3.1,!=34.3.2,"
258+
"!=36.2.0",
253259
install_requires=required,
254260
package_data={
255261
'advanced_descriptors': [

0 commit comments

Comments
 (0)