fix internal error in visitor91x (#232)

* fix internal error in visitor91x caused by different try/except sharing the same reference to self.try_state

* remove duplicated test case from eval_files/async900

Author: jakkdl

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 *[CalVer, YY.month.patch](https://calver.org/)*
 
+
+## 24.4.1
+- ASYNC91X fix internal error caused by multiple `try/except` incorrectly sharing state.
+
 ## 24.3.6
 - ASYNC100 no longer triggers if a context manager contains a `yield`.
 

flake8_async/__init__.py

@@ -37,7 +37,7 @@
 
 
 # CalVer: YY.month.patch, e.g. first release of July 2022 == "22.7.1"
-__version__ = "24.3.6"
+__version__ = "24.4.1"
 
 
 # taken from https://github.com/Zac-HD/shed

flake8_async/visitors/visitor91x.py

@@ -454,7 +454,7 @@ def leave_Yield(
     def visit_Try(self, node: cst.Try):
         if not self.async_function:
             return
-        self.save_state(node, "try_state")
+        self.save_state(node, "try_state", copy=True)
         # except & finally guaranteed to enter with checkpoint if checkpointed
         # before try and no yield in try body.
         self.try_state.body_uncheckpointed_statements = (
@@ -596,6 +596,8 @@ def visit_While_body(self, node: cst.For | cst.While):
         self.save_state(
             node,
             "uncheckpointed_statements",
+            # reference is overwritten below so don't need to copy
+            copy=False,
         )
 
         # inject an artificial uncheckpointed statement that won't raise an error,

tests/autofix_files/async910.py

@@ -601,3 +601,16 @@ async def await_in_gen_target():
 async def await_everywhere_except_gen_target():  # error: 0, "exit", Statement("function definition", lineno)
     (await x async for x in bar())
     await trio.lowlevel.checkpoint()
+
+
+# Issue #226
+async def fn_226():  # error: 0, "exit", Statement("function definition", lineno)
+    try:
+        while foo():
+            try:
+                await trio.sleep(1)
+            except Exception:
+                pass
+    except Exception:
+        pass
+    await trio.lowlevel.checkpoint()

tests/autofix_files/async910.py.diff

@@ -205,8 +205,16 @@
 
 
  async def foo_comprehension_3():
-@@ x,3 x,4 @@
+@@ x,6 x,7 @@
 
  async def await_everywhere_except_gen_target():  # error: 0, "exit", Statement("function definition", lineno)
      (await x async for x in bar())
 +    await trio.lowlevel.checkpoint()
+
+
+ # Issue #226
+@@ x,3 x,4 @@
+                 pass
+     except Exception:
+         pass
++    await trio.lowlevel.checkpoint()

tests/eval_files/async910.py

@@ -572,3 +572,15 @@ async def await_in_gen_target():
 
 async def await_everywhere_except_gen_target():  # error: 0, "exit", Statement("function definition", lineno)
     (await x async for x in bar())
+
+
+# Issue #226
+async def fn_226():  # error: 0, "exit", Statement("function definition", lineno)
+    try:
+        while foo():
+            try:
+                await trio.sleep(1)
+            except Exception:
+                pass
+    except Exception:
+        pass

tests/test_flake8_async.py

@@ -416,6 +416,7 @@ def _parse_eval_file(
                 msg = f"Line {lineno}: Failed to format\n {message!r}\nwith\n{args}"
                 raise ParseError(msg) from e
 
+    assert enabled_codes, "no codes enabled. Fix file name or add `# ARGS --enable=...`"
     enabled_codes_list = enabled_codes.split(",")
     for code in enabled_codes_list:
         assert re.fullmatch(