Merge pull request #488 from sdispater/improve-c-extensions-build

Improve C extensions building

Author: sdispater

.github/workflows/tests.yml

@@ -51,7 +51,7 @@ jobs:
     - name: Install dependencies
       run: |
         source $HOME/.poetry/env
-        poetry install
+        poetry install -vvv
     - name: Test Pure Python
       run: |
         source $HOME/.poetry/env
@@ -67,7 +67,7 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        python-version: [2.7, 3.5, 3.6, 3.7, 3.8, pypy2, pypy3]
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8, pypy3]
 
     steps:
     - uses: actions/checkout@v2
@@ -97,7 +97,7 @@ jobs:
     - name: Install dependencies
       run: |
         source $HOME/.poetry/env
-        poetry install
+        poetry install -vvv
     - name: Test Pure Python
       run: |
         source $HOME/.poetry/env
@@ -142,7 +142,7 @@ jobs:
     - name: Install dependencies
       run: |
         $env:Path += ";$env:Userprofile\.poetry\bin"
-        poetry install
+        poetry install -vvv
     - name: Test Pure Python
       run: |
         $env:Path += ";$env:Userprofile\.poetry\bin"

build.py

@@ -1,7 +1,9 @@
 import os
+import shutil
 import sys
 
 from distutils.command.build_ext import build_ext
+from distutils.core import Distribution
 from distutils.core import Extension
 from distutils.errors import CCompilerError
 from distutils.errors import DistutilsExecError
@@ -33,27 +35,53 @@ class BuildFailed(Exception):
 class ExtBuilder(build_ext):
     # This class allows C extension building to fail.
 
+    built_extensions = []
+
     def run(self):
         try:
             build_ext.run(self)
         except (DistutilsPlatformError, FileNotFoundError):
-            print("************************************************************")
-            print("Cannot compile C accelerator module, use pure python version")
-            print("************************************************************")
+            print(
+                "  Unable to build the C extensions, "
+                "Pendulum will use the pure python code instead."
+            )
 
     def build_extension(self, ext):
         try:
             build_ext.build_extension(self, ext)
         except (CCompilerError, DistutilsExecError, DistutilsPlatformError, ValueError):
-            print("************************************************************")
-            print("Cannot compile C accelerator module, use pure python version")
-            print("************************************************************")
+            print(
+                '  Unable to build the "{}" C extension, '
+                "Pendulum will use the pure python version of the extension.".format(
+                    ext.name
+                )
+            )
 
 
 def build(setup_kwargs):
     """
     This function is mandatory in order to build the extensions.
     """
-    setup_kwargs.update(
-        {"ext_modules": extensions, "cmdclass": {"build_ext": ExtBuilder}}
-    )
+    distribution = Distribution({"name": "pendulum", "ext_modules": extensions})
+    distribution.package_dir = "pendulum"
+
+    cmd = ExtBuilder(distribution)
+    cmd.ensure_finalized()
+    cmd.run()
+
+    # Copy built extensions back to the project
+    for output in cmd.get_outputs():
+        relative_extension = os.path.relpath(output, cmd.build_lib)
+        if not os.path.exists(output):
+            continue
+
+        shutil.copyfile(output, relative_extension)
+        mode = os.stat(relative_extension).st_mode
+        mode |= (mode & 0o444) >> 2
+        os.chmod(relative_extension, mode)
+
+    return setup_kwargs
+
+
+if __name__ == "__main__":
+    build({})