Fixed start_of() methods not setting microseconds to 0

Author: sdispater

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Fixed
 
 - Fixed the `weeks` property for negative `Period` instances.
+- Fixed `start_of()` methods not setting microseconds to 0.
 
 
 ## [2.0.1] - 2018-05-10

pendulum/datetime.py

@@ -844,7 +844,7 @@ def _start_of_day(self):
 
         :rtype: DateTime
         """
-        return self.at(0, 0, 0)
+        return self.at(0, 0, 0, 0)
 
     def _end_of_day(self):
         """
@@ -860,7 +860,7 @@ def _start_of_month(self):
 
         :rtype: DateTime
         """
-        return self.set(self.year, self.month, 1, 0, 0, 0)
+        return self.set(self.year, self.month, 1, 0, 0, 0, 0)
 
     def _end_of_month(self):
         """
@@ -879,7 +879,7 @@ def _start_of_year(self):
 
         :rtype: DateTime
         """
-        return self.set(self.year, 1, 1, 0, 0, 0)
+        return self.set(self.year, 1, 1, 0, 0, 0, 0)
 
     def _end_of_year(self):
         """
@@ -900,7 +900,7 @@ def _start_of_decade(self):
         :rtype: DateTime
         """
         year = self.year - self.year % YEARS_PER_DECADE
-        return self.set(year, 1, 1, 0, 0, 0)
+        return self.set(year, 1, 1, 0, 0, 0, 0)
 
     def _end_of_decade(self):
         """
@@ -924,7 +924,7 @@ def _start_of_century(self):
         """
         year = self.year - 1 - (self.year - 1) % YEARS_PER_CENTURY + 1
 
-        return self.set(year, 1, 1, 0, 0, 0)
+        return self.set(year, 1, 1, 0, 0, 0, 0)
 
     def _end_of_century(self):
         """

tests/datetime/test_start_end_of.py

@@ -50,7 +50,7 @@ def test_start_of_day():
     d = pendulum.now()
     new = d.start_of('day')
     assert isinstance(new, pendulum.DateTime)
-    assert_datetime(new, d.year, d.month, d.day, 0, 0, 0)
+    assert_datetime(new, d.year, d.month, d.day, 0, 0, 0, 0)
 
 
 def test_end_of_day():
@@ -68,13 +68,13 @@ def test_start_of_month_is_fluid():
 def test_start_of_month_from_now():
     d = pendulum.now()
     new = d.start_of('month')
-    assert_datetime(new, d.year, d.month, 1, 0, 0, 0)
+    assert_datetime(new, d.year, d.month, 1, 0, 0, 0, 0)
 
 
 def test_start_of_month_from_last_day():
     d = pendulum.datetime(2000, 1, 31, 2, 3, 4)
     new = d.start_of('month')
-    assert_datetime(new, 2000, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2000, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_year_is_fluid():
@@ -86,32 +86,26 @@ def test_start_of_year_is_fluid():
 def test_start_of_year_from_now():
     d = pendulum.now()
     new = d.start_of('year')
-    assert_datetime(new, d.year, 1, 1, 0, 0, 0)
+    assert_datetime(new, d.year, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_year_from_first_day():
     d = pendulum.datetime(2000, 1, 1, 1, 1, 1)
     new = d.start_of('year')
-    assert_datetime(new, 2000, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2000, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_year_from_last_day():
     d = pendulum.datetime(2000, 12, 31, 23, 59, 59)
     new = d.start_of('year')
-    assert_datetime(new, 2000, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2000, 1, 1, 0, 0, 0, 0)
 
 
 def test_end_of_month_is_fluid():
     d = pendulum.now()
     assert isinstance(d.end_of('month'), pendulum.DateTime)
 
 
-def test_end_of_month_from_now():
-    d = pendulum.now().start_of('month')
-    new = d.start_of('month')
-    assert_datetime(new, d.year, d.month, 1, 0, 0, 0)
-
-
 def test_end_of_month():
     d = pendulum.datetime(2000, 1, 1, 2, 3, 4).end_of('month')
     new = d.end_of('month')
@@ -155,19 +149,19 @@ def test_start_of_decade_is_fluid():
 def test_start_of_decade_from_now():
     d = pendulum.now()
     new = d.start_of('decade')
-    assert_datetime(new, d.year - d.year % 10, 1, 1, 0, 0, 0)
+    assert_datetime(new, d.year - d.year % 10, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_decade_from_first_day():
     d = pendulum.datetime(2000, 1, 1, 1, 1, 1)
     new = d.start_of('decade')
-    assert_datetime(new, 2000, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2000, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_decade_from_last_day():
     d = pendulum.datetime(2009, 12, 31, 23, 59, 59)
     new = d.start_of('decade')
-    assert_datetime(new, 2000, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2000, 1, 1, 0, 0, 0, 0)
 
 
 def test_end_of_decade_is_fluid():
@@ -201,19 +195,19 @@ def test_start_of_century_is_fluid():
 def test_start_of_century_from_now():
     d = pendulum.now()
     new = d.start_of('century')
-    assert_datetime(new, d.year - d.year % 100 + 1, 1, 1, 0, 0, 0)
+    assert_datetime(new, d.year - d.year % 100 + 1, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_century_from_first_day():
     d = pendulum.datetime(2001, 1, 1, 1, 1, 1)
     new = d.start_of('century')
-    assert_datetime(new, 2001, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2001, 1, 1, 0, 0, 0, 0)
 
 
 def test_start_of_century_from_last_day():
     d = pendulum.datetime(2100, 12, 31, 23, 59, 59)
     new = d.start_of('century')
-    assert_datetime(new, 2001, 1, 1, 0, 0, 0)
+    assert_datetime(new, 2001, 1, 1, 0, 0, 0, 0)
 
 
 def test_end_of_century_is_fluid():