Fix an error when comparing a Period to a timedelta in PyPy

Author: sdispater

.gitignore

@@ -19,6 +19,7 @@ nosetests.xml
 
 .DS_Store
 .idea/*
+.python-version
 
 /test.py
 /test_*.*

.travis.yml

@@ -19,6 +19,7 @@ matrix:
     - python: 3.6
       env: PENDULUM_EXTENSIONS=0
     - python: pypy
+    - python: pypy3
 
 before_install:
   - pip install codecov

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## [Unreleased]
+
+### Fixed
+
+- Fixed an error when comparing a Period to a timedelta in PyPy.
+
+
 ## [1.4.0] - 2018-01-22
 
 ### Changed

pendulum/period.py

@@ -3,7 +3,7 @@
 import operator
 import pendulum
 
-from datetime import datetime, date
+from datetime import datetime, date, timedelta
 
 from .mixins.interval import WordableIntervalMixin
 from .interval import BaseInterval, Interval
@@ -300,6 +300,17 @@ def __repr__(self):
             self._start, self._end
         )
 
+    def _cmp(self, other):
+        # Only needed for PyPy3
+        assert isinstance(other, timedelta)
+
+        if isinstance(other, Period):
+            other = other.as_timedelta()
+
+        td = self.as_timedelta()
+
+        return 0 if td == other else 1 if td > other else -1
+
     def _getstate(self, protocol=3):
         start, end = self.start, self.end
 

tests/period_tests/test_behavior.py

@@ -2,6 +2,9 @@
 
 import pickle
 import pendulum
+
+from datetime import timedelta
+
 from .. import AbstractTestCase
 
 
@@ -34,3 +37,11 @@ def test_pickle(self):
         self.assertEqual(p.start, p2.start)
         self.assertEqual(p.end, p2.end)
         self.assertEqual(p.invert, p2.invert)
+
+    def test_comparison_to_timedelta(self):
+        dt1 = pendulum.create(2016, 11, 18)
+        dt2 = pendulum.create(2016, 11, 20)
+
+        period = dt2 - dt1
+
+        assert period < timedelta(days=4)

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py{27,35,36}-{without,with}-extensions, pypy
+envlist = py{27,35,36}-{without,with}-extensions, pypy, pypy3
 
 [testenv]
 deps = -rtests-requirements.txt