property missing reference fix

Author: p1c2u

openapi_spec_validator/validation/validators.py

@@ -248,6 +248,7 @@ def _iter_schema_errors(
         if not hasattr(schema.content(), "__getitem__"):
             return
 
+        schema_type = schema.getkey("type")
         nested_properties = []
         if "allOf" in schema:
             all_of = schema / "allOf"
@@ -292,6 +293,14 @@ def _iter_schema_errors(
                 require_properties=False,
             )
 
+        if "properties" in schema:
+            props = schema /"properties"
+            for _, prop_schema in props.items():
+                yield from self._iter_schema_errors(
+                    prop_schema,
+                    require_properties=False,
+                )
+
         required = schema.getkey("required", [])
         properties = schema.get("properties", {}).keys()
         if "allOf" in schema:

tests/integration/data/v3.0/property-missing-reference.yaml

@@ -0,0 +1,16 @@
+openapi: 3.0.0
+info:
+  version: '1.0.0'
+  title: 'Some Schema'
+paths: {}
+components:
+  schemas:    
+    SomeDataType:
+      type: object
+      properties:
+        id:
+          type: integer
+        prop1:
+          $ref: '<some-broken-uri>'
+        prop2:
+          type: string

tests/integration/validation/test_validators.py

@@ -89,6 +89,20 @@ def test_failed(self, factory, validator_v30, spec_file):
         with pytest.raises(OpenAPIValidationError):
             validator_v30.validate(spec, spec_url=spec_url)
 
+    @pytest.mark.parametrize(
+        "spec_file",
+        [
+            "property-missing-reference.yaml",
+        ],
+    )
+    def test_ref_failed(self, factory, validator_v30, spec_file):
+        spec_path = self.local_test_suite_file_path(spec_file)
+        spec = factory.spec_from_file(spec_path)
+        spec_url = factory.spec_file_url(spec_path)
+
+        with pytest.raises(RefResolutionError):
+            validator_v30.validate(spec, spec_url=spec_url)
+
 
 @pytest.mark.network
 class TestRemoteOpenAPIv30Validator: