Switched to using requests rather than direct use of urllib3

- Use a StringIO buffer as YAML is stupid and won't use a Byte Stream

Author: Beirdo

openapi_spec_validator/handlers.py

@@ -1,9 +1,10 @@
 """OpenAPI spec validator handlers module."""
 import contextlib
+from io import StringIO
 
 from six.moves.urllib.parse import urlparse
-from six.moves.urllib.request import urlopen
 from yaml import load
+import requests
 
 from openapi_spec_validator.loaders import ExtendedSafeLoader
 
@@ -30,8 +31,16 @@ def __init__(self, *allowed_schemes, **options):
         self.allowed_schemes = allowed_schemes
 
     def __call__(self, url, timeout=1):
-        assert urlparse(url).scheme in self.allowed_schemes
-
-        f = urlopen(url, timeout=timeout)
-        with contextlib.closing(f) as fh:
+        scheme = urlparse(url).scheme
+        assert scheme in self.allowed_schemes
+
+        if scheme == "file":
+            filename = url[7:]
+            with open(filename) as fh:
+                return super(UrlHandler, self).__call__(fh)
+
+        response = requests.get(url, timeout=timeout)
+        response.raise_for_status()
+        data = response.text
+        with contextlib.closing(StringIO(data)) as fh:
             return super(UrlHandler, self).__call__(fh)

requirements.txt

@@ -1,3 +1,4 @@
 jsonschema
 PyYAML==4.2b4
 six==1.12.0
+requests

setup.cfg

@@ -29,6 +29,7 @@ install_requires =
     PyYAML>=5.1
     six
     pathlib2; python_version<"3.0"
+    requests
 tests_require =
     mock; python_version<"3.0"
     pytest