Falcon3 tests

Author: p1c2u

openapi_core/contrib/falcon/handlers.py

@@ -36,11 +36,16 @@ def handle(cls, req, resp, errors):
         data = {
             'errors': data_errors,
         }
+        data_str = dumps(data)
         data_error_max = max(data_errors, key=lambda x: x['status'])
         resp.content_type = MEDIA_JSON
         resp.status = cls.FALCON_STATUS_CODES.get(
             data_error_max['status'], HTTP_400)
-        resp.body = dumps(data)
+        # in falcon 3 body is deprecated
+        if hasattr(resp, 'text'):
+            resp.text = data_str
+        else:
+            resp.body = data_str
         resp.complete = True
 
     @classmethod

openapi_core/contrib/falcon/responses.py

@@ -13,8 +13,14 @@ def create(cls, response):
         else:
             mimetype = response.options.default_media_type
 
+        # in falcon 3 body is deprecated
+        if hasattr(response, "text"):
+            data = response.text
+        else:
+            data = response.body
+
         return OpenAPIResponse(
-            data=response.body,
+            data=data,
             status_code=status_code,
             mimetype=mimetype,
         )

requirements_dev.txt

@@ -2,7 +2,7 @@ mock==2.0.0
 pytest==3.5.0
 pytest-flake8
 pytest-cov==2.5.1
-falcon==2.0.0
+falcon==3.0.0
 flask
 django==2.2.18; python_version>="3.0"
 requests==2.22.0

tests/integration/contrib/falcon/conftest.py

@@ -43,7 +43,7 @@ def create_response(
             data, status_code=200, content_type='application/json'):
         options = ResponseOptions()
         resp = Response(options)
-        resp.body = data
+        resp.text = data
         resp.content_type = content_type
         resp.status = HTTP_200
         return resp

tests/integration/contrib/falcon/test_falcon_middlewares.py

@@ -1,6 +1,6 @@
 from json import dumps
 
-from falcon import API
+from falcon import App
 from falcon.testing import TestClient
 import pytest
 
@@ -24,7 +24,7 @@ def middleware(self, spec):
 
     @pytest.fixture
     def app(self, middleware):
-        return API(middleware=[middleware])
+        return App(middleware=[middleware])
 
     @pytest.yield_fixture
     def client(self, app):
@@ -67,7 +67,7 @@ def view_response_callable(request, response, id):
             })
             response.content_type = MEDIA_HTML
             response.status = HTTP_200
-            response.body = 'success'
+            response.text = 'success'
         self.view_response_callable = view_response_callable
         headers = {'Content-Type': 'application/json'}
         result = client.simulate_get(
@@ -190,7 +190,7 @@ def view_response_callable(request, response, id):
             })
             response.status = HTTP_200
             response.content_type = MEDIA_JSON
-            response.body = dumps({
+            response.text = dumps({
                 'data': 'data',
             })
         self.view_response_callable = view_response_callable