Merge pull request #276 from jgod/master

ArrayUnmarshaller: return None on nullable type instead of "NoneType object is not iterable" crash

Author: p1c2u

openapi_core/unmarshalling/schemas/unmarshallers.py

@@ -144,7 +144,8 @@ def items_unmarshaller(self):
 
     def __call__(self, value=NoValue):
         value = super(ArrayUnmarshaller, self).__call__(value)
-
+        if value is None and self.schema.nullable:
+            return None
         return list(map(self.items_unmarshaller, value))
 
 

tests/unit/unmarshalling/test_unmarshal.py

@@ -352,6 +352,27 @@ def test_array_valid(self, unmarshaller_factory):
 
         assert result == value
 
+    def test_array_null(self, unmarshaller_factory):
+        schema = Schema(
+            'array',
+            items=Schema('integer'),
+        )
+        value = None
+
+        with pytest.raises(TypeError):
+            unmarshaller_factory(schema)(value)
+
+    def test_array_nullable(self, unmarshaller_factory):
+        schema = Schema(
+            'array',
+            items=Schema('integer'),
+            nullable=True,
+        )
+        value = None
+        result = unmarshaller_factory(schema)(value)
+
+        assert result is None
+
     def test_array_of_string_string_invalid(self, unmarshaller_factory):
         schema = Schema('array', items=Schema('string'))
         value = '123'