Merge pull request #589 from python-openapi/fix/validate-request-response-deprecation-warning-fix

validate_request and validate_response return value deprecation fix

Author: p1c2u

openapi_core/shortcuts.py

@@ -5,6 +5,8 @@
 from typing import Optional
 from typing import Union
 
+from lazy_object_proxy import Proxy
+
 from openapi_core.exceptions import SpecError
 from openapi_core.finders import SpecClasses
 from openapi_core.finders import SpecFinder
@@ -317,19 +319,24 @@ def validate_request(
     if cls is None or issubclass(
         cls, (RequestUnmarshaller, WebhookRequestUnmarshaller)
     ):
-        warnings.warn(
-            "validate_request is deprecated for unmarshalling data "
-            "and it will not return any result in the future. "
-            "Use unmarshal_request function instead.",
-            DeprecationWarning,
-        )
-        return unmarshal_request(
+        result = unmarshal_request(
             request,
             spec=spec,
             base_url=base_url,
             cls=cls,
             **validator_kwargs,
         )
+
+        def return_result() -> RequestUnmarshalResult:
+            warnings.warn(
+                "validate_request is deprecated for unmarshalling data "
+                "and it will not return any result in the future. "
+                "Use unmarshal_request function instead.",
+                DeprecationWarning,
+            )
+            return result
+
+        return Proxy(return_result)  # type: ignore
     if isinstance(request, WebhookRequest):
         if cls is None or issubclass(cls, WebhookRequestValidator):
             validate_webhook_request(
@@ -400,20 +407,25 @@ def validate_response(
     if cls is None or issubclass(
         cls, (ResponseUnmarshaller, WebhookResponseUnmarshaller)
     ):
-        warnings.warn(
-            "validate_response is deprecated for unmarshalling data "
-            "and it will not return any result in the future. "
-            "Use unmarshal_response function instead.",
-            DeprecationWarning,
-        )
-        return unmarshal_response(
+        result = unmarshal_response(
             request,
             response,
             spec=spec,
             base_url=base_url,
             cls=cls,
             **validator_kwargs,
         )
+
+        def return_result() -> ResponseUnmarshalResult:
+            warnings.warn(
+                "validate_response is deprecated for unmarshalling data "
+                "and it will not return any result in the future. "
+                "Use unmarshal_response function instead.",
+                DeprecationWarning,
+            )
+            return result
+
+        return Proxy(return_result)  # type: ignore
     if isinstance(request, WebhookRequest):
         if cls is None or issubclass(cls, WebhookResponseValidator):
             validate_webhook_response(

poetry.lock

@@ -27,6 +27,10 @@ module = [
 ]
 ignore_missing_imports = true
 
+[[tool.mypy.overrides]]
+module = "lazy_object_proxy.*"
+ignore_missing_imports = true
+
 [tool.poetry]
 name = "openapi-core"
 version = "0.17.1"
@@ -74,6 +78,7 @@ backports-cached-property = {version = "^1.0.2", python = "<3.8" }
 asgiref = "^3.6.0"
 jsonschema = "^4.17.3"
 multidict = {version = "^6.0.4", optional = true}
+lazy-object-proxy = "^1.7.1"
 
 [tool.poetry.extras]
 django = ["django"]