Unmarshal any schema type

Author: p1c2u

openapi_core/schema/schemas/exceptions.py

@@ -5,6 +5,14 @@ class OpenAPISchemaError(OpenAPIMappingError):
     pass
 
 
+class NoValidSchema(OpenAPISchemaError):
+    pass
+
+
+class UndefinedItemsSchema(OpenAPISchemaError):
+    pass
+
+
 class InvalidSchemaValue(OpenAPISchemaError):
     pass
 

openapi_core/schema/schemas/models.py

@@ -10,7 +10,8 @@
 from openapi_core.schema.schemas.enums import SchemaFormat, SchemaType
 from openapi_core.schema.schemas.exceptions import (
     InvalidSchemaValue, UndefinedSchemaProperty, MissingSchemaProperty,
-    OpenAPISchemaError, NoOneOfSchema, MultipleOneOfSchema,
+    OpenAPISchemaError, NoOneOfSchema, MultipleOneOfSchema, NoValidSchema,
+    UndefinedItemsSchema,
 )
 from openapi_core.schema.schemas.util import (
     forcebool, format_date, format_datetime,
@@ -26,7 +27,6 @@ class Schema(object):
     """Represents an OpenAPI Schema."""
 
     DEFAULT_CAST_CALLABLE_GETTER = {
-        SchemaType.ANY: lambda x: x,
         SchemaType.INTEGER: int,
         SchemaType.NUMBER: float,
         SchemaType.BOOLEAN: forcebool,
@@ -47,7 +47,7 @@ class Schema(object):
     }
 
     TYPE_VALIDATOR_CALLABLE_GETTER = {
-        None: lambda x: True,
+        SchemaType.ANY: lambda x: x,
         SchemaType.BOOLEAN: TypeValidator(bool),
         SchemaType.INTEGER: TypeValidator(integer_types, exclude=bool),
         SchemaType.NUMBER: TypeValidator(integer_types, float, exclude=bool),
@@ -108,7 +108,7 @@ def _get_all_required_properties(self):
 
         return dict(
             (prop_name, val)
-            for prop_name, val in all_properties.items()
+            for prop_name, val in iteritems(all_properties)
             if prop_name in required
         )
 
@@ -125,6 +125,7 @@ def get_cast_mapping(self):
         mapping = self.DEFAULT_CAST_CALLABLE_GETTER.copy()
         mapping.update({
             SchemaType.STRING: self._unmarshal_string,
+            SchemaType.ANY: self._unmarshal_any,
             SchemaType.ARRAY: self._unmarshal_collection,
             SchemaType.OBJECT: self._unmarshal_object,
         })
@@ -154,8 +155,8 @@ def cast(self, value):
     def unmarshal(self, value):
         """Unmarshal parameter from the value."""
         if self.deprecated:
-            warnings.warn(
-                "The schema is deprecated", DeprecationWarning)
+            warnings.warn("The schema is deprecated", DeprecationWarning)
+
         casted = self.cast(value)
 
         if casted is None and not self.required:
@@ -188,7 +189,27 @@ def _unmarshal_string(self, value):
                     value, self.format)
             )
 
+    def _unmarshal_any(self, value):
+        types_resolve_order = [
+            SchemaType.OBJECT, SchemaType.ARRAY, SchemaType.BOOLEAN,
+            SchemaType.INTEGER, SchemaType.NUMBER, SchemaType.STRING,
+        ]
+        cast_mapping = self.get_cast_mapping()
+        for schema_type in types_resolve_order:
+            cast_callable = cast_mapping[schema_type]
+            try:
+                return cast_callable(value)
+            # @todo: remove ValueError when validation separated
+            except (OpenAPISchemaError, TypeError, ValueError):
+                continue
+
+        raise NoValidSchema(
+            "No valid schema found for value {0}".format(value))
+
     def _unmarshal_collection(self, value):
+        if self.items is None:
+            raise UndefinedItemsSchema("Undefined items' schema")
+
         return list(map(self.items.unmarshal, value))
 
     def _unmarshal_object(self, value, model_factory=None):

tests/integration/test_petstore.py

@@ -17,6 +17,7 @@
 from openapi_core.schema.responses.models import Response
 from openapi_core.schema.schemas.exceptions import (
     UndefinedSchemaProperty, MissingSchemaProperty, NoOneOfSchema,
+    NoValidSchema,
 )
 from openapi_core.schema.schemas.models import Schema
 from openapi_core.schema.servers.exceptions import InvalidServer
@@ -1037,9 +1038,10 @@ def test_post_tags_created_now(
             self, spec, response_validator):
         host_url = 'http://petstore.swagger.io/v1'
         path_pattern = '/v1/tags'
+        created = 'now'
         pet_name = 'Dog'
         data_json = {
-            'created': 'now',
+            'created': created,
             'name': pet_name,
         }
         data = json.dumps(data_json)
@@ -1053,8 +1055,14 @@ def test_post_tags_created_now(
         body = request.get_body(spec)
 
         assert parameters == {}
-        assert body == data_json
+        assert isinstance(body, BaseModel)
+        assert body.created == created
+        assert body.name == pet_name
 
+        code = 400
+        message = 'Bad request'
+        rootCause = 'Tag already exist'
+        additionalinfo = 'Tag Dog already exist'
         data_json = {
             'code': 400,
             'message': 'Bad request',
@@ -1067,15 +1075,20 @@ def test_post_tags_created_now(
         response_result = response_validator.validate(request, response)
 
         assert response_result.errors == []
-        assert response_result.data == data_json
+        assert isinstance(response_result.data, BaseModel)
+        assert response_result.data.code == code
+        assert response_result.data.message == message
+        assert response_result.data.rootCause == rootCause
+        assert response_result.data.additionalinfo == additionalinfo
 
     def test_post_tags_created_datetime(
             self, spec, response_validator):
         host_url = 'http://petstore.swagger.io/v1'
         path_pattern = '/v1/tags'
+        created = '2016-04-16T16:06:05Z'
         pet_name = 'Dog'
         data_json = {
-            'created': '2016-04-16T16:06:05Z',
+            'created': created,
             'name': pet_name,
         }
         data = json.dumps(data_json)
@@ -1089,13 +1102,65 @@ def test_post_tags_created_datetime(
         body = request.get_body(spec)
 
         assert parameters == {}
-        assert body == data_json
+        assert isinstance(body, BaseModel)
+        assert body.created == created
+        assert body.name == pet_name
 
+        code = 400
+        message = 'Bad request'
+        rootCause = 'Tag already exist'
+        additionalinfo = 'Tag Dog already exist'
         data_json = {
-            'code': 400,
-            'message': 'Bad request',
-            'rootCause': 'Tag already exist',
-            'additionalinfo': 'Tag Dog already exist',
+            'code': code,
+            'message': message,
+            'rootCause': rootCause,
+            'additionalinfo': additionalinfo,
+        }
+        data = json.dumps(data_json)
+        response = MockResponse(data, status_code=404)
+
+        response_result = response_validator.validate(request, response)
+
+        assert response_result.errors == []
+        assert isinstance(response_result.data, BaseModel)
+        assert response_result.data.code == code
+        assert response_result.data.message == message
+        assert response_result.data.rootCause == rootCause
+        assert response_result.data.additionalinfo == additionalinfo
+
+    @pytest.mark.xfail(reason='OneOf for string not supported atm')
+    def test_post_tags_created_invalid_type(
+            self, spec, response_validator):
+        host_url = 'http://petstore.swagger.io/v1'
+        path_pattern = '/v1/tags'
+        created = 'long time ago'
+        pet_name = 'Dog'
+        data_json = {
+            'created': created,
+            'name': pet_name,
+        }
+        data = json.dumps(data_json)
+
+        request = MockRequest(
+            host_url, 'POST', '/tags',
+            path_pattern=path_pattern, data=data,
+        )
+
+        parameters = request.get_parameters(spec)
+        with pytest.raises(NoValidSchema):
+            request.get_body(spec)
+
+        assert parameters == {}
+
+        code = 400
+        message = 'Bad request'
+        rootCause = 'Tag already exist'
+        additionalinfo = 'Tag Dog already exist'
+        data_json = {
+            'code': code,
+            'message': message,
+            'rootCause': rootCause,
+            'additionalinfo': additionalinfo,
         }
         data = json.dumps(data_json)
         response = MockResponse(data, status_code=404)