GH action and fix linter (#160)

* Fix lint

* Added GH Action

Author: avara1986

.github/workflows/python-package.yml

@@ -0,0 +1,47 @@
+# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
+
+name: Python package
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.7, 3.8]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install pipenv
+        pipenv lock --dev --requirements > requirements.txt
+        pip install -r requirements.txt
+    - name: Test with pytest
+      run: |
+        python setup.py test
+    - name: Lint with flake8
+      run: |
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 pyms --show-source --statistics --statistics
+    - name: Lint with pylint
+      run: |
+        pylint --rcfile=pylintrc pyms
+    - name: Security safety
+      run: |
+        safety check
+    - name: Security bandit
+      run: |
+        bandit -r pyms/

.travis.yml

@@ -1,13 +1,14 @@
 language: python
 python:
-  - "3.6"
-  - "3.7"
   - "3.8"
 install:
-  - pip install --upgrade setuptools tox tox-travis coveralls
+  - python -m pip install --upgrade pip
+  - pip install --upgrade setuptools coveralls pipenv
+  - pipenv lock --dev --requirements > requirements.txt
+  - pip install -r requirements.txt
 script:
   - coverage erase
-  - tox
+  - python setup.py test
 after_success:
   - coverage combine
   - coveralls

Pipfile

@@ -8,6 +8,3 @@ py-ms = {editable = true,extras = ["tests"],path = "."}
 
 [packages]
 py-ms = {editable = true,extras = ["all"],path = "."}
-
-[requires]
-python_version = "3.7"

Pipfile.lock

@@ -51,7 +51,7 @@ def __init__(self, *args, **kwargs):
 
         config = self.set_config(config)
 
-        super(ConfFile, self).__init__(config)
+        super().__init__(config)
 
     def to_flask(self) -> Dict:
         return ConfFile(config={k.upper(): v for k, v in self.items()}, crypt=self._crypt_cls)
@@ -110,10 +110,10 @@ def __getattr__(self, name, *args, **kwargs):
             for k in keys:
                 aux_dict = aux_dict[k]
             return aux_dict
-        except KeyError:
+        except KeyError as e:
             if self._empty_init:
                 return ConfFile(config={}, empty_init=self._empty_init, crypt=self._crypt_cls)
-            raise AttrDoesNotExistException("Variable {} not exist in the config file".format(name))
+            raise AttrDoesNotExistException("Variable {} not exist in the config file".format(name)) from e
 
     def reload(self):
         """
@@ -124,4 +124,4 @@ def reload(self):
         self.set_config(config_src)
 
     def __setattr__(self, name, value, *args, **kwargs):
-        super(ConfFile, self).__setattr__(name, value)
+        super().__setattr__(name, value)

pyms/config/confile.py

@@ -77,7 +77,7 @@ class MetricsLogHandler(logging.Handler):
     """A LogHandler that exports logging metrics for Prometheus.io."""
 
     def __init__(self, app_name):
-        super(MetricsLogHandler, self).__init__()
+        super().__init__()
         self.app_name = app_name
 
     def emit(self, record):

pyms/flask/services/metrics.py

@@ -16,7 +16,7 @@ class CustomJsonFormatter(jsonlogger.JsonFormatter):
     tracer = ""
 
     def add_fields(self, log_record, record, message_dict):
-        super(CustomJsonFormatter, self).add_fields(log_record, record, message_dict)
+        super().add_fields(log_record, record, message_dict)
         if not log_record.get('timestamp'):
             # this doesn't use record.created, so it is slightly off
             now = datetime.datetime.utcnow().strftime('%Y-%m-%dT%H:%M:%S.%fZ')

pyms/logger/logger.py

@@ -1,5 +1,11 @@
 [aliases]
-test=pytest
+test = pytest
 
 [tool:pytest]
-addopts = --cov=pyms --cov=tests tests/
+addopts = --cov=pyms --cov=tests tests/
+
+[flake8]
+ignore = E501
+exclude = .git,__pycache__,docs/source/conf.py,old,build,dist
+max-complexity = 12
+max-line-length = 120

setup.cfg

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright (c) 2018 by Alberto Vara <albertovara@paradigmadigital.com>
 import codecs
 import os

setup.py

@@ -34,7 +34,7 @@ commands =
 [testenv:flake8]
 basepython = python3.7
 commands =
-    flake8 --ignore=E501 {toxinidir}/pyms
+    flake8 {toxinidir}/pyms --show-source --statistics --statistics
 [testenv:docs]
 basepython = python3.7
 skipsdist = True