more expressive name and doc

Author: Richardk2n

test/test_plugin.py

@@ -18,7 +18,8 @@
 
 
 @pytest.fixture
-def diag_mp(monkeypatch):
+def last_diagnostics_monkeypatch(monkeypatch):
+    # gets called before every test altering last_diagnostics in order to reset it
     monkeypatch.setattr(plugin, "last_diagnostics", collections.defaultdict(list))
     return monkeypatch
 
@@ -45,7 +46,7 @@ def test_settings():
     assert settings == {"plugins": {"pylsp_mypy": {}}}
 
 
-def test_plugin(workspace, diag_mp):
+def test_plugin(workspace, last_diagnostics_monkeypatch):
     config = FakeConfig()
     doc = Document(DOC_URI, workspace, DOC_TYPE_ERR)
     plugin.pylsp_settings(config)
@@ -92,7 +93,7 @@ def test_parse_line_with_context(monkeypatch, word, bounds, workspace):
     assert diag["range"]["end"] == {"line": 278, "character": bounds[1]}
 
 
-def test_multiple_workspaces(tmpdir, diag_mp):
+def test_multiple_workspaces(tmpdir, last_diagnostics_monkeypatch):
     DOC_SOURCE = """
 def foo():
     return
@@ -137,7 +138,7 @@ def test_apply_overrides():
     assert plugin.apply_overrides(["1"], ["a", True, "b"]) == ["a", "1", "b"]
 
 
-def test_option_overrides(tmpdir, diag_mp, workspace):
+def test_option_overrides(tmpdir, last_diagnostics_monkeypatch, workspace):
     import sys
     from textwrap import dedent
     from stat import S_IRWXU
@@ -158,7 +159,7 @@ def test_option_overrides(tmpdir, diag_mp, workspace):
     wrapper.chmod(S_IRWXU)
 
     overrides = ["--python-executable", wrapper.strpath, True]
-    diag_mp.setattr(
+    last_diagnostics_monkeypatch.setattr(
         FakeConfig,
         "plugin_settings",
         lambda _, p: {"overrides": overrides} if p == "pylsp_mypy" else {},
@@ -176,9 +177,9 @@ def test_option_overrides(tmpdir, diag_mp, workspace):
     assert sentinel.exists()
 
 
-def test_option_overrides_dmypy(diag_mp, workspace):
+def test_option_overrides_dmypy(last_diagnostics_monkeypatch, workspace):
     overrides = ["--python-executable", "/tmp/fake", True]
-    diag_mp.setattr(
+    last_diagnostics_monkeypatch.setattr(
         FakeConfig,
         "plugin_settings",
         lambda _, p: {
@@ -191,7 +192,7 @@ def test_option_overrides_dmypy(diag_mp, workspace):
     )
 
     m = Mock(wraps=lambda a, **_: Mock(returncode=0, **{"stdout.decode": lambda: ""}))
-    diag_mp.setattr(plugin.subprocess, "run", m)
+    last_diagnostics_monkeypatch.setattr(plugin.subprocess, "run", m)
 
     plugin.pylsp_lint(
         config=FakeConfig(),