Lint

Author: domdfcoding

snippet_fmt/__init__.py

@@ -56,7 +56,7 @@
 __version__: str = "0.1.4"
 __email__: str = "dominic@davis-foster.co.uk"
 
-__all__ = ["CodeBlockError", "RSTReformatter", "reformat_file"]
+__all__ = ("CodeBlockError", "RSTReformatter", "reformat_file")
 
 TRAILING_NL_RE = re.compile(r'\n+\Z', re.MULTILINE)
 
@@ -227,7 +227,7 @@ def load_extra_formatters(self) -> None:
 		for distro_config, _ in entrypoints.iter_files_distros():
 			if group in distro_config:
 				for name, epstr in distro_config[group].items():
-					with contextlib.suppress(entrypoints.BadEntryPoint, ImportError):
+					with contextlib.suppress(entrypoints.BadEntryPoint, ImportError):  # pylint: disable=W8205
 						# TODO: show warning for bad entry point if verbose, or "strict"?
 						ep = entrypoints.EntryPoint.from_string(epstr, name)
 						self._formatters[name] = ep.load()
@@ -237,7 +237,7 @@ def reformat_file(
 		filename: PathLike,
 		config: SnippetFmtConfigDict,
 		colour: ColourTrilean = None,
-		):
+		) -> int:
 	"""
 	Reformat the given reStructuredText file, and show the diff if changes were made.
 

snippet_fmt/__main__.py

@@ -38,7 +38,7 @@
 from consolekit.tracebacks import handle_tracebacks, traceback_option
 from domdf_python_tools.typing import PathLike
 
-__all__ = ["main"]
+__all__ = ("main", )
 
 
 @flag_option("--diff", "show_diff", help="Show a diff of changes made")
@@ -71,7 +71,7 @@ def main(
 		verbose: bool = False,
 		show_traceback: bool = False,
 		show_diff: bool = False,
-		):
+		) -> None:
 	"""
 	Reformat code snippets in the given reStructuredText files.
 	"""
@@ -97,7 +97,7 @@ def main(
 
 	for path in filename:
 		for pattern in exclude or []:
-			if re.match(fnmatch.translate(pattern), str(path)):
+			if re.match(fnmatch.translate(pattern), str(path)):  # pylint: disable=loop-invariant-statement
 				continue
 
 		path = PathPlus(path).abspath()

snippet_fmt/config.py

@@ -34,7 +34,7 @@
 from domdf_python_tools.typing import PathLike
 from typing_extensions import TypedDict
 
-__all__ = ["SnippetFmtConfigDict", "load_toml"]
+__all__ = ("SnippetFmtConfigDict", "load_toml")
 
 
 class SnippetFmtConfigDict(TypedDict):
@@ -98,7 +98,7 @@ def load_toml(filename: PathLike) -> SnippetFmtConfigDict:
 
 	if "languages" in config:
 		for language, lang_config in config.get("languages", {}).items():
-			snippet_fmt_config["languages"][language] = lang_config
+			snippet_fmt_config["languages"][language] = lang_config  # pylint: disable=loop-invariant-statement
 	else:
 		snippet_fmt_config["languages"] = {
 				"python": {},

snippet_fmt/formatters.py

@@ -32,22 +32,22 @@
 import os
 from configparser import ConfigParser
 from io import StringIO
-from typing import Any, Callable, Optional, TypeVar
+from typing import Any, Optional
 
 # 3rd party
 import dom_toml
 import dom_toml.decoder
 import formate
 from domdf_python_tools.paths import PathPlus
 
-__all__ = [
+__all__ = (
 		"Formatter",
 		"format_toml",
 		"format_ini",
 		"format_json",
 		"format_python",
 		"noformat",
-		]
+		)
 
 # 3rd party
 from typing_extensions import Protocol

tests/test_snippet_fmt.py

@@ -1,6 +1,5 @@
 # stdlib
-import re
-from typing import Dict, List, Union, no_type_check
+from typing import Dict, Iterator, List, Union, no_type_check
 
 # 3rd party
 import dom_toml
@@ -69,7 +68,7 @@
 
 
 @pytest.fixture()
-def custom_entry_point(monkeypatch):
+def custom_entry_point(monkeypatch) -> Iterator:
 	with TemporaryPathPlus() as tmpdir:
 		monkeypatch.syspath_prepend(str(tmpdir))
 
@@ -114,6 +113,7 @@ def test_snippet_fmt(
 		advanced_file_regression.check_file(tmp_pathplus / filename)
 		check_out(capsys.readouterr(), tmp_pathplus, advanced_data_regression)
 
+	@pytest.mark.usefixtures("custom_entry_point")
 	@filenames
 	def test_snippet_fmt_custom_entry_point(
 			self,
@@ -122,7 +122,6 @@ def test_snippet_fmt_custom_entry_point(
 			advanced_file_regression: AdvancedFileRegressionFixture,
 			advanced_data_regression: AdvancedDataRegressionFixture,
 			capsys,
-			custom_entry_point
 			):
 
 		languages = {"python3": {"reformat": True}}
@@ -191,7 +190,7 @@ def check_out(
 		result: Union[Result, CaptureResult[str]],
 		tmpdir: PathPlus,
 		advanced_data_regression: AdvancedDataRegressionFixture,
-		):
+		) -> None:
 
 	if hasattr(result, "stdout"):
 		stdout = result.stdout